Explorar o código

PCI: ibmphp: Fix use-before-set in get_max_bus_speed()

The "rc" variable is only initialized on the error path.  The caller
doesn't check the return but, if "rc" is non-zero, then this function is
basically a no-op.

Fixes: 3749c51ac6c1 ("PCI: Make current and maximum bus speeds part of the PCI core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Dan Carpenter %!s(int64=7) %!d(string=hai) anos
pai
achega
4051f5ebb1
Modificáronse 1 ficheiros con 1 adicións e 1 borrados
  1. 1 1
      drivers/pci/hotplug/ibmphp_core.c

+ 1 - 1
drivers/pci/hotplug/ibmphp_core.c

@@ -379,7 +379,7 @@ static int get_adapter_present(struct hotplug_slot *hotplug_slot, u8 *value)
 
 static int get_max_bus_speed(struct slot *slot)
 {
-	int rc;
+	int rc = 0;
 	u8 mode = 0;
 	enum pci_bus_speed speed;
 	struct pci_bus *bus = slot->hotplug_slot->pci_slot->bus;