瀏覽代碼

amd-xgbe: Stop the PHY before releasing interrupts

Some configurations require the use of the hardware's MDIO support to
communicate with external PHYs. The MDIO commands indicate completion
through the device interrupt. When bringing down the device the interrupts
were released before stopping the external PHY, resulting in MDIO command
timeouts. Move the stopping of the PHY to before the releasing of the
interrupts.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Lendacky, Thomas 8 年之前
父節點
當前提交
402168b4c2
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+ 2 - 2
drivers/net/ethernet/amd/xgbe/xgbe-drv.c

@@ -1131,12 +1131,12 @@ static void xgbe_stop(struct xgbe_prv_data *pdata)
 	hw_if->disable_tx(pdata);
 	hw_if->disable_tx(pdata);
 	hw_if->disable_rx(pdata);
 	hw_if->disable_rx(pdata);
 
 
+	phy_if->phy_stop(pdata);
+
 	xgbe_free_irqs(pdata);
 	xgbe_free_irqs(pdata);
 
 
 	xgbe_napi_disable(pdata, 1);
 	xgbe_napi_disable(pdata, 1);
 
 
-	phy_if->phy_stop(pdata);
-
 	hw_if->exit(pdata);
 	hw_if->exit(pdata);
 
 
 	channel = pdata->channel;
 	channel = pdata->channel;