Browse Source

fsl/fman: fix error return code in mac_probe()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3933961682a3 ("fsl/fman: Add FMan MAC driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Wei Yongjun 8 years ago
parent
commit
3f3177bb68
1 changed files with 6 additions and 2 deletions
  1. 6 2
      drivers/net/ethernet/freescale/fman/mac.c

+ 6 - 2
drivers/net/ethernet/freescale/fman/mac.c

@@ -879,13 +879,17 @@ static int mac_probe(struct platform_device *_of_dev)
 
 
 		priv->fixed_link = kzalloc(sizeof(*priv->fixed_link),
 		priv->fixed_link = kzalloc(sizeof(*priv->fixed_link),
 					   GFP_KERNEL);
 					   GFP_KERNEL);
-		if (!priv->fixed_link)
+		if (!priv->fixed_link) {
+			err = -ENOMEM;
 			goto _return_dev_set_drvdata;
 			goto _return_dev_set_drvdata;
+		}
 
 
 		priv->phy_node = of_node_get(mac_node);
 		priv->phy_node = of_node_get(mac_node);
 		phy = of_phy_find_device(priv->phy_node);
 		phy = of_phy_find_device(priv->phy_node);
-		if (!phy)
+		if (!phy) {
+			err = -EINVAL;
 			goto _return_dev_set_drvdata;
 			goto _return_dev_set_drvdata;
+		}
 
 
 		priv->fixed_link->link = phy->link;
 		priv->fixed_link->link = phy->link;
 		priv->fixed_link->speed = phy->speed;
 		priv->fixed_link->speed = phy->speed;