Эх сурвалжийг харах

staging: lustre: Cleaning up unnecessary use of memset in conjunction with strncpy

Using memset before strncpy just to ensure a trailing null
character is an unnecessary double writing of a string

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rickard Strandqvist 11 жил өмнө
parent
commit
3f2882d369

+ 1 - 1
drivers/staging/lustre/lustre/libcfs/debug.c

@@ -401,9 +401,9 @@ int libcfs_debug_init(unsigned long bufsize)
 	}
 	}
 
 
 	if (libcfs_debug_file_path != NULL) {
 	if (libcfs_debug_file_path != NULL) {
-		memset(libcfs_debug_file_path_arr, 0, PATH_MAX);
 		strncpy(libcfs_debug_file_path_arr,
 		strncpy(libcfs_debug_file_path_arr,
 			libcfs_debug_file_path, PATH_MAX-1);
 			libcfs_debug_file_path, PATH_MAX-1);
+		libcfs_debug_file_path_arr[PATH_MAX - 1] = '\0';
 	}
 	}
 
 
 	/* If libcfs_debug_mb is set to an invalid value or uninitialized
 	/* If libcfs_debug_mb is set to an invalid value or uninitialized