Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

rtnl: fix the loop index update error in rtnl_dump_ifinfo()

If the link is filtered out, loop index should also be updated. If not,
loop index will not be correct.

Fixes: dc599f76c22b0 ("net: Add support for filtering link dump by master device and kind")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Zhang Shengju 8 years ago
parent
32c231164b
commit
3f0ae05d6f
1 changed files with 1 additions and 1 deletions
Unified View Show Diff Stats
  1. 1 1
      net/core/rtnetlink.c

+ 1 - 1
net/core/rtnetlink.c
View File 

@@ -1609,7 +1609,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
 
 		head = &net->dev_index_head[h];
 
 		head = &net->dev_index_head[h];
 
 		hlist_for_each_entry(dev, head, index_hlist) {
 
 		hlist_for_each_entry(dev, head, index_hlist) {
 
 			if (link_dump_filtered(dev, master_idx, kind_ops))
 
 			if (link_dump_filtered(dev, master_idx, kind_ops))
 
-				continue;
 
+				goto cont;
 
 			if (idx < s_idx)
 
 			if (idx < s_idx)
 
 				goto cont;
 
 				goto cont;
 
 			err = rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,
 
 			err = rtnl_fill_ifinfo(skb, dev, RTM_NEWLINK,