Browse Source

[media] saa7134-i2c: simplify debug dump and use pr_info()

Instead of implement its own hexdump logic, use the printk
format, and convert to use pr_info().

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Mauro Carvalho Chehab 10 years ago
parent
commit
3e0051c5a4
1 changed files with 5 additions and 6 deletions
  1. 5 6
      drivers/media/pci/saa7134/saa7134-i2c.c

+ 5 - 6
drivers/media/pci/saa7134/saa7134-i2c.c

@@ -369,13 +369,12 @@ saa7134_i2c_eeprom(struct saa7134_dev *dev, unsigned char *eedata, int len)
 		       dev->name,err);
 		return -1;
 	}
-	for (i = 0; i < len; i++) {
-		if (0 == (i % 16))
-			pr_info("%s: i2c eeprom %02x:",dev->name,i);
-		printk(" %02x",eedata[i]);
-		if (15 == (i % 16))
-			printk("\n");
+
+	for (i = 0; i < len; i+= 16) {
+		int size = (len - i) > 16 ? 16 : len - i;
+		pr_info("i2c eeprom %02x: %*ph\n", i, size, &eedata[i]);
 	}
+
 	return 0;
 }