Browse Source

mpt3sas: fix Kconfig dependency problem for mpt2sas back compatibility

The non-PCI builds of the O day test project are failing:

On Thu, 2015-12-03 at 05:02 +0800, kbuild test robot wrote:
> warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct
> dependencies (SCSI_LOWLEVEL && PCI && SCSI)

The problem is that select and depend don't interact because Kconfig doesn't
have a SAT solver, so depend picks up dependencies and select does onward
selects, but select doesn't pick up dependencies.  To fix this, we need to add
the correct dependencies to the MPT2SAS option like this.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: b840c3627b6f4f856b333a14a72f8ed86da2f86c
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
James Bottomley 9 years ago
parent
commit
3ddda3e4c8
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/scsi/mpt3sas/Kconfig

+ 1 - 0
drivers/scsi/mpt3sas/Kconfig

@@ -76,6 +76,7 @@ config SCSI_MPT2SAS
 	tristate "Legacy MPT2SAS config option"
 	default n
 	select SCSI_MPT3SAS
+	depends on PCI && SCSI
 	---help---
 	Dummy config option for backwards compatiblity: configure the MPT3SAS
 	driver instead.