浏览代码

drm/amdgpu: revert "fix deadlock of reservation between cs and gpu reset v2"

This reverts commit 10e709cb296c98424c03408d23e3addeddcd4088.

The patch doesn't work at all:
1. The CS can still be blocked because of amdgpu_ctx_add_fence().
2. The order of submission isn't correct any more.
3. We could end up using freed up memory because we now drop the
   ctx reference to early.

This needs to be fixed cleanly by doing the context handling after the BO
handling, but this is a larger task just avoid the obvious crashes for now.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Monk Liu monk.liu@amd.com
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Christian König 8 年之前
父节点
当前提交
3d138c14c4
共有 1 个文件被更改,包括 0 次插入4 次删除
  1. 0 4
      drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+ 0 - 4
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

@@ -1153,7 +1153,6 @@ static int amdgpu_cs_submit(struct amdgpu_cs_parser *p,
 	cs->out.handle = amdgpu_ctx_add_fence(p->ctx, ring, p->fence);
 	cs->out.handle = amdgpu_ctx_add_fence(p->ctx, ring, p->fence);
 	job->uf_sequence = cs->out.handle;
 	job->uf_sequence = cs->out.handle;
 	amdgpu_job_free_resources(job);
 	amdgpu_job_free_resources(job);
-	amdgpu_cs_parser_fini(p, 0, true);
 
 
 	trace_amdgpu_cs_ioctl(job);
 	trace_amdgpu_cs_ioctl(job);
 	amd_sched_entity_push_job(&job->base);
 	amd_sched_entity_push_job(&job->base);
@@ -1211,10 +1210,7 @@ int amdgpu_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
 		goto out;
 		goto out;
 
 
 	r = amdgpu_cs_submit(&parser, cs);
 	r = amdgpu_cs_submit(&parser, cs);
-	if (r)
-		goto out;
 
 
-	return 0;
 out:
 out:
 	amdgpu_cs_parser_fini(&parser, r, reserved_buffers);
 	amdgpu_cs_parser_fini(&parser, r, reserved_buffers);
 	return r;
 	return r;