浏览代码

dmaengine: mmp-tdma: fix terminate_all return code

In a recent cleanup, the mmp_tdma_terminate_all function was
introduced but does not set a proper return value. Almost
no slave driver uses that return value, but if one does, the
result will be undefined, which the compiler warns about:

dma/mmp_tdma.c: In function 'mmp_tdma_terminate_all':
dma/mmp_tdma.c:474:1: warning: no return statement in function returning non-void [-Wreturn-type]

This changes the driver to return zero, like most other
drivers do.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: f43a6fd400ba6 ("dmaengine: mmp-tdma: Split device_control")
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Arnd Bergmann 10 年之前
父节点
当前提交
3c20ba5fb5
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      drivers/dma/mmp_tdma.c

+ 2 - 0
drivers/dma/mmp_tdma.c

@@ -471,6 +471,8 @@ static int mmp_tdma_terminate_all(struct dma_chan *chan)
 	mmp_tdma_disable_chan(chan);
 	mmp_tdma_disable_chan(chan);
 	/* disable interrupt */
 	/* disable interrupt */
 	mmp_tdma_enable_irq(tdmac, false);
 	mmp_tdma_enable_irq(tdmac, false);
+
+	return 0;
 }
 }
 
 
 static int mmp_tdma_config(struct dma_chan *chan,
 static int mmp_tdma_config(struct dma_chan *chan,