PCI/MSI: Return failure when msix_setup_entries() fails · 3adfb572f2 - Gogs: Go Git Service GfA electronic

PCI/MSI: Return failure when msix_setup_entries() fails

If alloc_msi_entry() fails, we free resources and set ret = -ENOMEM.

However, msix_setup_entries() returns 0 unconditionally.  Return the error
code instead.

Fixes: e75eafb9b039 ("genirq/msi: Switch to new irq spreading infrastructure")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Christophe JAILLET 8 years ago

parent

4fe0395550

commit

3adfb572f2

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
drivers/pci/msi.c
							 
								View File
							
				@@ -731,7 +731,7 @@ static int msix_setup_entries(struct pci_dev *dev, void __iomem *base,
			
				 	ret = 0;
			
				 out:
			
				 	kfree(masks);
			
				-	return 0;
			
				+	return ret;
			
				 }
			
				 static void msix_program_entries(struct pci_dev *dev,