|
@@ -28,14 +28,12 @@
|
|
|
#include <linux/power/gpio-charger.h>
|
|
|
|
|
|
struct gpio_charger {
|
|
|
- const struct gpio_charger_platform_data *pdata;
|
|
|
unsigned int irq;
|
|
|
bool wakeup_enabled;
|
|
|
|
|
|
struct power_supply *charger;
|
|
|
struct power_supply_desc charger_desc;
|
|
|
struct gpio_desc *gpiod;
|
|
|
- bool legacy_gpio_requested;
|
|
|
};
|
|
|
|
|
|
static irqreturn_t gpio_charger_irq(int irq, void *devid)
|
|
@@ -56,13 +54,10 @@ static int gpio_charger_get_property(struct power_supply *psy,
|
|
|
enum power_supply_property psp, union power_supply_propval *val)
|
|
|
{
|
|
|
struct gpio_charger *gpio_charger = psy_to_gpio_charger(psy);
|
|
|
- const struct gpio_charger_platform_data *pdata = gpio_charger->pdata;
|
|
|
|
|
|
switch (psp) {
|
|
|
case POWER_SUPPLY_PROP_ONLINE:
|
|
|
val->intval = gpiod_get_value_cansleep(gpio_charger->gpiod);
|
|
|
- /* This xor is only ever used with legacy pdata GPIO */
|
|
|
- val->intval ^= pdata->gpio_active_low;
|
|
|
break;
|
|
|
default:
|
|
|
return -EINVAL;
|
|
@@ -71,175 +66,134 @@ static int gpio_charger_get_property(struct power_supply *psy,
|
|
|
return 0;
|
|
|
}
|
|
|
|
|
|
-static enum power_supply_property gpio_charger_properties[] = {
|
|
|
- POWER_SUPPLY_PROP_ONLINE,
|
|
|
-};
|
|
|
-
|
|
|
-static
|
|
|
-struct gpio_charger_platform_data *gpio_charger_parse_dt(struct device *dev)
|
|
|
+static enum power_supply_type gpio_charger_get_type(struct device *dev)
|
|
|
{
|
|
|
- struct device_node *np = dev->of_node;
|
|
|
- struct gpio_charger_platform_data *pdata;
|
|
|
const char *chargetype;
|
|
|
- int ret;
|
|
|
-
|
|
|
- if (!np)
|
|
|
- return ERR_PTR(-ENOENT);
|
|
|
-
|
|
|
- pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
|
|
|
- if (!pdata)
|
|
|
- return ERR_PTR(-ENOMEM);
|
|
|
-
|
|
|
- pdata->name = np->name;
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_UNKNOWN;
|
|
|
- ret = of_property_read_string(np, "charger-type", &chargetype);
|
|
|
- if (ret >= 0) {
|
|
|
- if (!strncmp("unknown", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_UNKNOWN;
|
|
|
- else if (!strncmp("battery", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_BATTERY;
|
|
|
- else if (!strncmp("ups", chargetype, 3))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_UPS;
|
|
|
- else if (!strncmp("mains", chargetype, 5))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_MAINS;
|
|
|
- else if (!strncmp("usb-sdp", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_USB;
|
|
|
- else if (!strncmp("usb-dcp", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_USB_DCP;
|
|
|
- else if (!strncmp("usb-cdp", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_USB_CDP;
|
|
|
- else if (!strncmp("usb-aca", chargetype, 7))
|
|
|
- pdata->type = POWER_SUPPLY_TYPE_USB_ACA;
|
|
|
- else
|
|
|
- dev_warn(dev, "unknown charger type %s\n", chargetype);
|
|
|
+
|
|
|
+ if (!device_property_read_string(dev, "charger-type", &chargetype)) {
|
|
|
+ if (!strcmp("unknown", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_UNKNOWN;
|
|
|
+ if (!strcmp("battery", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_BATTERY;
|
|
|
+ if (!strcmp("ups", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_UPS;
|
|
|
+ if (!strcmp("mains", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_MAINS;
|
|
|
+ if (!strcmp("usb-sdp", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_USB;
|
|
|
+ if (!strcmp("usb-dcp", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_USB_DCP;
|
|
|
+ if (!strcmp("usb-cdp", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_USB_CDP;
|
|
|
+ if (!strcmp("usb-aca", chargetype))
|
|
|
+ return POWER_SUPPLY_TYPE_USB_ACA;
|
|
|
}
|
|
|
+ dev_warn(dev, "unknown charger type %s\n", chargetype);
|
|
|
|
|
|
- return pdata;
|
|
|
+ return POWER_SUPPLY_TYPE_UNKNOWN;
|
|
|
}
|
|
|
|
|
|
+static enum power_supply_property gpio_charger_properties[] = {
|
|
|
+ POWER_SUPPLY_PROP_ONLINE,
|
|
|
+};
|
|
|
+
|
|
|
static int gpio_charger_probe(struct platform_device *pdev)
|
|
|
{
|
|
|
- const struct gpio_charger_platform_data *pdata = pdev->dev.platform_data;
|
|
|
+ struct device *dev = &pdev->dev;
|
|
|
+ const struct gpio_charger_platform_data *pdata = dev->platform_data;
|
|
|
struct power_supply_config psy_cfg = {};
|
|
|
struct gpio_charger *gpio_charger;
|
|
|
struct power_supply_desc *charger_desc;
|
|
|
- int ret;
|
|
|
- int irq;
|
|
|
-
|
|
|
- if (!pdata) {
|
|
|
- pdata = gpio_charger_parse_dt(&pdev->dev);
|
|
|
- if (IS_ERR(pdata)) {
|
|
|
- ret = PTR_ERR(pdata);
|
|
|
- if (ret != -EPROBE_DEFER)
|
|
|
- dev_err(&pdev->dev, "No platform data\n");
|
|
|
- return ret;
|
|
|
- }
|
|
|
+ unsigned long flags;
|
|
|
+ int irq, ret;
|
|
|
+
|
|
|
+ if (!pdata && !dev->of_node) {
|
|
|
+ dev_err(dev, "No platform data\n");
|
|
|
+ return -ENOENT;
|
|
|
}
|
|
|
|
|
|
- gpio_charger = devm_kzalloc(&pdev->dev, sizeof(*gpio_charger),
|
|
|
- GFP_KERNEL);
|
|
|
- if (!gpio_charger) {
|
|
|
- dev_err(&pdev->dev, "Failed to alloc driver structure\n");
|
|
|
+ gpio_charger = devm_kzalloc(dev, sizeof(*gpio_charger), GFP_KERNEL);
|
|
|
+ if (!gpio_charger)
|
|
|
return -ENOMEM;
|
|
|
- }
|
|
|
|
|
|
/*
|
|
|
* This will fetch a GPIO descriptor from device tree, ACPI or
|
|
|
* boardfile descriptor tables. It's good to try this first.
|
|
|
*/
|
|
|
- gpio_charger->gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_IN);
|
|
|
+ gpio_charger->gpiod = devm_gpiod_get(dev, NULL, GPIOD_IN);
|
|
|
|
|
|
/*
|
|
|
* If this fails and we're not using device tree, try the
|
|
|
* legacy platform data method.
|
|
|
*/
|
|
|
- if (IS_ERR(gpio_charger->gpiod) && !pdev->dev.of_node) {
|
|
|
+ if (IS_ERR(gpio_charger->gpiod) && !dev->of_node) {
|
|
|
/* Non-DT: use legacy GPIO numbers */
|
|
|
if (!gpio_is_valid(pdata->gpio)) {
|
|
|
- dev_err(&pdev->dev, "Invalid gpio pin in pdata\n");
|
|
|
+ dev_err(dev, "Invalid gpio pin in pdata\n");
|
|
|
return -EINVAL;
|
|
|
}
|
|
|
- ret = gpio_request(pdata->gpio, dev_name(&pdev->dev));
|
|
|
+ flags = GPIOF_IN;
|
|
|
+ if (pdata->gpio_active_low)
|
|
|
+ flags |= GPIOF_ACTIVE_LOW;
|
|
|
+ ret = devm_gpio_request_one(dev, pdata->gpio, flags,
|
|
|
+ dev_name(dev));
|
|
|
if (ret) {
|
|
|
- dev_err(&pdev->dev, "Failed to request gpio pin: %d\n",
|
|
|
- ret);
|
|
|
+ dev_err(dev, "Failed to request gpio pin: %d\n", ret);
|
|
|
return ret;
|
|
|
}
|
|
|
- gpio_charger->legacy_gpio_requested = true;
|
|
|
- ret = gpio_direction_input(pdata->gpio);
|
|
|
- if (ret) {
|
|
|
- dev_err(&pdev->dev, "Failed to set gpio to input: %d\n",
|
|
|
- ret);
|
|
|
- goto err_gpio_free;
|
|
|
- }
|
|
|
/* Then convert this to gpiod for now */
|
|
|
gpio_charger->gpiod = gpio_to_desc(pdata->gpio);
|
|
|
} else if (IS_ERR(gpio_charger->gpiod)) {
|
|
|
/* Just try again if this happens */
|
|
|
if (PTR_ERR(gpio_charger->gpiod) == -EPROBE_DEFER)
|
|
|
return -EPROBE_DEFER;
|
|
|
- dev_err(&pdev->dev, "error getting GPIO descriptor\n");
|
|
|
+ dev_err(dev, "error getting GPIO descriptor\n");
|
|
|
return PTR_ERR(gpio_charger->gpiod);
|
|
|
}
|
|
|
|
|
|
charger_desc = &gpio_charger->charger_desc;
|
|
|
-
|
|
|
- charger_desc->name = pdata->name ? pdata->name : "gpio-charger";
|
|
|
- charger_desc->type = pdata->type;
|
|
|
charger_desc->properties = gpio_charger_properties;
|
|
|
charger_desc->num_properties = ARRAY_SIZE(gpio_charger_properties);
|
|
|
charger_desc->get_property = gpio_charger_get_property;
|
|
|
|
|
|
- psy_cfg.supplied_to = pdata->supplied_to;
|
|
|
- psy_cfg.num_supplicants = pdata->num_supplicants;
|
|
|
- psy_cfg.of_node = pdev->dev.of_node;
|
|
|
+ psy_cfg.of_node = dev->of_node;
|
|
|
psy_cfg.drv_data = gpio_charger;
|
|
|
|
|
|
- gpio_charger->pdata = pdata;
|
|
|
+ if (pdata) {
|
|
|
+ charger_desc->name = pdata->name;
|
|
|
+ charger_desc->type = pdata->type;
|
|
|
+ psy_cfg.supplied_to = pdata->supplied_to;
|
|
|
+ psy_cfg.num_supplicants = pdata->num_supplicants;
|
|
|
+ } else {
|
|
|
+ charger_desc->name = dev->of_node->name;
|
|
|
+ charger_desc->type = gpio_charger_get_type(dev);
|
|
|
+ }
|
|
|
+
|
|
|
+ if (!charger_desc->name)
|
|
|
+ charger_desc->name = pdev->name;
|
|
|
|
|
|
- gpio_charger->charger = power_supply_register(&pdev->dev,
|
|
|
- charger_desc, &psy_cfg);
|
|
|
+ gpio_charger->charger = devm_power_supply_register(dev, charger_desc,
|
|
|
+ &psy_cfg);
|
|
|
if (IS_ERR(gpio_charger->charger)) {
|
|
|
ret = PTR_ERR(gpio_charger->charger);
|
|
|
- dev_err(&pdev->dev, "Failed to register power supply: %d\n",
|
|
|
- ret);
|
|
|
- goto err_gpio_free;
|
|
|
+ dev_err(dev, "Failed to register power supply: %d\n", ret);
|
|
|
+ return ret;
|
|
|
}
|
|
|
|
|
|
irq = gpiod_to_irq(gpio_charger->gpiod);
|
|
|
if (irq > 0) {
|
|
|
- ret = request_any_context_irq(irq, gpio_charger_irq,
|
|
|
+ ret = devm_request_any_context_irq(dev, irq, gpio_charger_irq,
|
|
|
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
|
|
|
- dev_name(&pdev->dev), gpio_charger->charger);
|
|
|
+ dev_name(dev), gpio_charger->charger);
|
|
|
if (ret < 0)
|
|
|
- dev_warn(&pdev->dev, "Failed to request irq: %d\n", ret);
|
|
|
+ dev_warn(dev, "Failed to request irq: %d\n", ret);
|
|
|
else
|
|
|
gpio_charger->irq = irq;
|
|
|
}
|
|
|
|
|
|
platform_set_drvdata(pdev, gpio_charger);
|
|
|
|
|
|
- device_init_wakeup(&pdev->dev, 1);
|
|
|
-
|
|
|
- return 0;
|
|
|
-
|
|
|
-err_gpio_free:
|
|
|
- if (gpio_charger->legacy_gpio_requested)
|
|
|
- gpio_free(pdata->gpio);
|
|
|
- return ret;
|
|
|
-}
|
|
|
-
|
|
|
-static int gpio_charger_remove(struct platform_device *pdev)
|
|
|
-{
|
|
|
- struct gpio_charger *gpio_charger = platform_get_drvdata(pdev);
|
|
|
-
|
|
|
- if (gpio_charger->irq)
|
|
|
- free_irq(gpio_charger->irq, gpio_charger->charger);
|
|
|
-
|
|
|
- power_supply_unregister(gpio_charger->charger);
|
|
|
-
|
|
|
- if (gpio_charger->legacy_gpio_requested)
|
|
|
- gpio_free(gpio_charger->pdata->gpio);
|
|
|
+ device_init_wakeup(dev, 1);
|
|
|
|
|
|
return 0;
|
|
|
}
|
|
@@ -280,7 +234,6 @@ MODULE_DEVICE_TABLE(of, gpio_charger_match);
|
|
|
|
|
|
static struct platform_driver gpio_charger_driver = {
|
|
|
.probe = gpio_charger_probe,
|
|
|
- .remove = gpio_charger_remove,
|
|
|
.driver = {
|
|
|
.name = "gpio-charger",
|
|
|
.pm = &gpio_charger_pm_ops,
|