Browse Source

ieee802154: ca8210: Delete an error message for a failed memory allocation in ca8210_skb_rx()

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Markus Elfring 8 years ago
parent
commit
3a21bf586d
1 changed files with 2 additions and 3 deletions
  1. 2 3
      drivers/net/ieee802154/ca8210.c

+ 2 - 3
drivers/net/ieee802154/ca8210.c

@@ -1808,10 +1808,9 @@ static int ca8210_skb_rx(
 
 
 	/* Allocate mtu size buffer for every rx packet */
 	/* Allocate mtu size buffer for every rx packet */
 	skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr));
 	skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr));
-	if (!skb) {
-		dev_crit(&priv->spi->dev, "dev_alloc_skb failed\n");
+	if (!skb)
 		return -ENOMEM;
 		return -ENOMEM;
-	}
+
 	skb_reserve(skb, sizeof(hdr));
 	skb_reserve(skb, sizeof(hdr));
 
 
 	msdulen = data_ind[22]; /* msdu_length */
 	msdulen = data_ind[22]; /* msdu_length */