Эх сурвалжийг харах

btree: catch NULL value before it does harm

Storing NULL values in the btree is illegal and can lead to memory
corruption and possible other fun as well.  Catch it on insert, instead
of waiting for the inevitable.

Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Joern Engel 13 жил өмнө
parent
commit
39caa0916e
1 өөрчлөгдсөн 1 нэмэгдсэн , 0 устгасан
  1. 1 0
      lib/btree.c

+ 1 - 0
lib/btree.c

@@ -509,6 +509,7 @@ retry:
 int btree_insert(struct btree_head *head, struct btree_geo *geo,
 int btree_insert(struct btree_head *head, struct btree_geo *geo,
 		unsigned long *key, void *val, gfp_t gfp)
 		unsigned long *key, void *val, gfp_t gfp)
 {
 {
+	BUG_ON(!val);
 	return btree_insert_level(head, geo, key, val, 1, gfp);
 	return btree_insert_level(head, geo, key, val, 1, gfp);
 }
 }
 EXPORT_SYMBOL_GPL(btree_insert);
 EXPORT_SYMBOL_GPL(btree_insert);