Browse Source

TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev

Add newly registered TPMs to the tail of the list, not the beginning, so that
things that are specifying TPM_ANY_NUM don't find that the device they're
using has inadvertently changed.  Adding a second device would break IMA, for
instance.

Cc: stable@vger.kernel.org
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
David Howells 11 năm trước cách đây
mục cha
commit
398a1e71dc
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/char/tpm/tpm-interface.c

+ 1 - 1
drivers/char/tpm/tpm-interface.c

@@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(struct device *dev,
 
 
 	/* Make chip available */
 	/* Make chip available */
 	spin_lock(&driver_lock);
 	spin_lock(&driver_lock);
-	list_add_rcu(&chip->list, &tpm_chip_list);
+	list_add_tail_rcu(&chip->list, &tpm_chip_list);
 	spin_unlock(&driver_lock);
 	spin_unlock(&driver_lock);
 
 
 	return chip;
 	return chip;