浏览代码

perf list: Make vendor event matching case insensitive

Make the 'perf list' glob matching for vendor events case insensitive.
This allows to use the upper case vendor events with perf list too.

Now the following works:

  % perf list LONGEST_LAT

  ...

  cache:
    longest_lat_cache.miss
         [Core-originated cacheable demand requests missed LLC]
    longest_lat_cache.reference
         [Core-originated cacheable demand requests that refer to LLC]

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Suggested-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/1476899402-31460-1-git-send-email-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Andi Kleen 8 年之前
父节点
当前提交
38d14f0c58
共有 3 个文件被更改,包括 19 次插入7 次删除
  1. 2 2
      tools/perf/util/pmu.c
  2. 16 5
      tools/perf/util/string.c
  3. 1 0
      tools/perf/util/util.h

+ 2 - 2
tools/perf/util/pmu.c

@@ -1139,8 +1139,8 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag,
 			bool is_cpu = !strcmp(pmu->name, "cpu");
 			bool is_cpu = !strcmp(pmu->name, "cpu");
 
 
 			if (event_glob != NULL &&
 			if (event_glob != NULL &&
-			    !(strglobmatch(name, event_glob) ||
-			      (!is_cpu && strglobmatch(alias->name,
+			    !(strglobmatch_nocase(name, event_glob) ||
+			      (!is_cpu && strglobmatch_nocase(alias->name,
 						       event_glob))))
 						       event_glob))))
 				continue;
 				continue;
 
 

+ 16 - 5
tools/perf/util/string.c

@@ -193,7 +193,8 @@ error:
 }
 }
 
 
 /* Glob/lazy pattern matching */
 /* Glob/lazy pattern matching */
-static bool __match_glob(const char *str, const char *pat, bool ignore_space)
+static bool __match_glob(const char *str, const char *pat, bool ignore_space,
+			bool case_ins)
 {
 {
 	while (*str && *pat && *pat != '*') {
 	while (*str && *pat && *pat != '*') {
 		if (ignore_space) {
 		if (ignore_space) {
@@ -219,8 +220,13 @@ static bool __match_glob(const char *str, const char *pat, bool ignore_space)
 				return false;
 				return false;
 		else if (*pat == '\\') /* Escaped char match as normal char */
 		else if (*pat == '\\') /* Escaped char match as normal char */
 			pat++;
 			pat++;
-		if (*str++ != *pat++)
+		if (case_ins) {
+			if (tolower(*str) != tolower(*pat))
+				return false;
+		} else if (*str != *pat)
 			return false;
 			return false;
+		str++;
+		pat++;
 	}
 	}
 	/* Check wild card */
 	/* Check wild card */
 	if (*pat == '*') {
 	if (*pat == '*') {
@@ -229,7 +235,7 @@ static bool __match_glob(const char *str, const char *pat, bool ignore_space)
 		if (!*pat)	/* Tail wild card matches all */
 		if (!*pat)	/* Tail wild card matches all */
 			return true;
 			return true;
 		while (*str)
 		while (*str)
-			if (__match_glob(str++, pat, ignore_space))
+			if (__match_glob(str++, pat, ignore_space, case_ins))
 				return true;
 				return true;
 	}
 	}
 	return !*str && !*pat;
 	return !*str && !*pat;
@@ -249,7 +255,12 @@ static bool __match_glob(const char *str, const char *pat, bool ignore_space)
  */
  */
 bool strglobmatch(const char *str, const char *pat)
 bool strglobmatch(const char *str, const char *pat)
 {
 {
-	return __match_glob(str, pat, false);
+	return __match_glob(str, pat, false, false);
+}
+
+bool strglobmatch_nocase(const char *str, const char *pat)
+{
+	return __match_glob(str, pat, false, true);
 }
 }
 
 
 /**
 /**
@@ -262,7 +273,7 @@ bool strglobmatch(const char *str, const char *pat)
  */
  */
 bool strlazymatch(const char *str, const char *pat)
 bool strlazymatch(const char *str, const char *pat)
 {
 {
-	return __match_glob(str, pat, true);
+	return __match_glob(str, pat, true, false);
 }
 }
 
 
 /**
 /**

+ 1 - 0
tools/perf/util/util.h

@@ -222,6 +222,7 @@ s64 perf_atoll(const char *str);
 char **argv_split(const char *str, int *argcp);
 char **argv_split(const char *str, int *argcp);
 void argv_free(char **argv);
 void argv_free(char **argv);
 bool strglobmatch(const char *str, const char *pat);
 bool strglobmatch(const char *str, const char *pat);
+bool strglobmatch_nocase(const char *str, const char *pat);
 bool strlazymatch(const char *str, const char *pat);
 bool strlazymatch(const char *str, const char *pat);
 static inline bool strisglob(const char *str)
 static inline bool strisglob(const char *str)
 {
 {