Эх сурвалжийг харах

usb: chipidea: udc: Use dma_pool_zalloc()

We can make the code simpler by using dma_pool_zalloc() instead
of calling dma_pool_alloc() and then a memset().

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Fabio Estevam 9 жил өмнө
parent
commit
382c1b38d8

+ 2 - 4
drivers/usb/chipidea/udc.c

@@ -1677,12 +1677,10 @@ static int init_eps(struct ci_hdrc *ci)
 			usb_ep_set_maxpacket_limit(&hwep->ep, (unsigned short)~0);
 			usb_ep_set_maxpacket_limit(&hwep->ep, (unsigned short)~0);
 
 
 			INIT_LIST_HEAD(&hwep->qh.queue);
 			INIT_LIST_HEAD(&hwep->qh.queue);
-			hwep->qh.ptr = dma_pool_alloc(ci->qh_pool, GFP_KERNEL,
-						     &hwep->qh.dma);
+			hwep->qh.ptr = dma_pool_zalloc(ci->qh_pool, GFP_KERNEL,
+						       &hwep->qh.dma);
 			if (hwep->qh.ptr == NULL)
 			if (hwep->qh.ptr == NULL)
 				retval = -ENOMEM;
 				retval = -ENOMEM;
-			else
-				memset(hwep->qh.ptr, 0, sizeof(*hwep->qh.ptr));
 
 
 			/*
 			/*
 			 * set up shorthands for ep0 out and in endpoints,
 			 * set up shorthands for ep0 out and in endpoints,