浏览代码

NFS: silence a harmless uninitialized variable warning

kstrtoul() can return -ERANGE so Smatch complains that "num" can be
uninitialized.  We check that it's within bounds so it's not a huge
deal.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Dan Carpenter 7 年之前
父节点
当前提交
379ebf0796
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      fs/nfs/super.c

+ 1 - 1
fs/nfs/super.c

@@ -2899,7 +2899,7 @@ static int param_set_portnr(const char *val, const struct kernel_param *kp)
 	if (!val)
 	if (!val)
 		return -EINVAL;
 		return -EINVAL;
 	ret = kstrtoul(val, 0, &num);
 	ret = kstrtoul(val, 0, &num);
-	if (ret == -EINVAL || num > NFS_CALLBACK_MAXPORTNR)
+	if (ret || num > NFS_CALLBACK_MAXPORTNR)
 		return -EINVAL;
 		return -EINVAL;
 	*((unsigned int *)kp->arg) = num;
 	*((unsigned int *)kp->arg) = num;
 	return 0;
 	return 0;