Просмотр исходного кода

drm/mgag200: Remove unecessary NULL check in bo_unref

ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Daniel Vetter 11 лет назад
Родитель
Сommit
36b347fb31
1 измененных файлов с 1 добавлено и 3 удалено
  1. 1 3
      drivers/gpu/drm/mgag200/mgag200_main.c

+ 1 - 3
drivers/gpu/drm/mgag200/mgag200_main.c

@@ -322,9 +322,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo)
 
 	tbo = &((*bo)->bo);
 	ttm_bo_unref(&tbo);
-	if (tbo == NULL)
-		*bo = NULL;
-
+	*bo = NULL;
 }
 
 void mgag200_gem_free_object(struct drm_gem_object *obj)