Przeglądaj źródła

phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_on/off()

There's no reason to store the return value of rockchip_emmc_phy_power()
in a variable nor to check it.  Just return it.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Douglas Anderson 9 lat temu
rodzic
commit
352051ef1f
1 zmienionych plików z 2 dodań i 12 usunięć
  1. 2 12
      drivers/phy/phy-rockchip-emmc.c

+ 2 - 12
drivers/phy/phy-rockchip-emmc.c

@@ -169,20 +169,14 @@ static int rockchip_emmc_phy_power(struct rockchip_emmc_phy *rk_phy,
 static int rockchip_emmc_phy_power_off(struct phy *phy)
 static int rockchip_emmc_phy_power_off(struct phy *phy)
 {
 {
 	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);
 	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);
-	int ret = 0;
 
 
 	/* Power down emmc phy analog blocks */
 	/* Power down emmc phy analog blocks */
-	ret = rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_OFF);
-	if (ret)
-		return ret;
-
-	return 0;
+	return rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_OFF);
 }
 }
 
 
 static int rockchip_emmc_phy_power_on(struct phy *phy)
 static int rockchip_emmc_phy_power_on(struct phy *phy)
 {
 {
 	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);
 	struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy);
-	int ret = 0;
 
 
 	/* DLL operation: 200 MHz */
 	/* DLL operation: 200 MHz */
 	regmap_write(rk_phy->reg_base,
 	regmap_write(rk_phy->reg_base,
@@ -213,11 +207,7 @@ static int rockchip_emmc_phy_power_on(struct phy *phy)
 				   PHYCTRL_OTAPDLYSEL_SHIFT));
 				   PHYCTRL_OTAPDLYSEL_SHIFT));
 
 
 	/* Power up emmc phy analog blocks */
 	/* Power up emmc phy analog blocks */
-	ret = rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_ON);
-	if (ret)
-		return ret;
-
-	return 0;
+	return rockchip_emmc_phy_power(rk_phy, PHYCTRL_PDB_PWR_ON);
 }
 }
 
 
 static const struct phy_ops ops = {
 static const struct phy_ops ops = {