浏览代码

orangefs: some error code paths missed kmem_cache_free

If a slab cache object is allocated, it needs to be freed eventually,
certainly before anyone unloads the module that allocated it.

Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Mike Marshall 6 年之前
父节点
当前提交
34e6148a2c
共有 1 个文件被更改,包括 3 次插入3 次删除
  1. 3 3
      fs/orangefs/namei.c

+ 3 - 3
fs/orangefs/namei.c

@@ -58,7 +58,6 @@ static int orangefs_create(struct inode *dir,
 		goto out;
 		goto out;
 
 
 	ref = new_op->downcall.resp.create.refn;
 	ref = new_op->downcall.resp.create.refn;
-	op_release(new_op);
 
 
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFREG | mode, 0, &ref);
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFREG | mode, 0, &ref);
 	if (IS_ERR(inode)) {
 	if (IS_ERR(inode)) {
@@ -92,6 +91,7 @@ static int orangefs_create(struct inode *dir,
 	mark_inode_dirty_sync(dir);
 	mark_inode_dirty_sync(dir);
 	ret = 0;
 	ret = 0;
 out:
 out:
+	op_release(new_op);
 	gossip_debug(GOSSIP_NAME_DEBUG,
 	gossip_debug(GOSSIP_NAME_DEBUG,
 		     "%s: %pd: returning %d\n",
 		     "%s: %pd: returning %d\n",
 		     __func__,
 		     __func__,
@@ -269,7 +269,6 @@ static int orangefs_symlink(struct inode *dir,
 	}
 	}
 
 
 	ref = new_op->downcall.resp.sym.refn;
 	ref = new_op->downcall.resp.sym.refn;
-	op_release(new_op);
 
 
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFLNK | mode, 0, &ref);
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFLNK | mode, 0, &ref);
 	if (IS_ERR(inode)) {
 	if (IS_ERR(inode)) {
@@ -307,6 +306,7 @@ static int orangefs_symlink(struct inode *dir,
 	mark_inode_dirty_sync(dir);
 	mark_inode_dirty_sync(dir);
 	ret = 0;
 	ret = 0;
 out:
 out:
+	op_release(new_op);
 	return ret;
 	return ret;
 }
 }
 
 
@@ -346,7 +346,6 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode
 	}
 	}
 
 
 	ref = new_op->downcall.resp.mkdir.refn;
 	ref = new_op->downcall.resp.mkdir.refn;
-	op_release(new_op);
 
 
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFDIR | mode, 0, &ref);
 	inode = orangefs_new_inode(dir->i_sb, dir, S_IFDIR | mode, 0, &ref);
 	if (IS_ERR(inode)) {
 	if (IS_ERR(inode)) {
@@ -379,6 +378,7 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode
 	orangefs_inode_setattr(dir, &iattr);
 	orangefs_inode_setattr(dir, &iattr);
 	mark_inode_dirty_sync(dir);
 	mark_inode_dirty_sync(dir);
 out:
 out:
+	op_release(new_op);
 	return ret;
 	return ret;
 }
 }