Browse Source

mmc: mxcmmc: catch all errors when getting regulators

Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Wolfram Sang 7 years ago
parent
commit
337d7c8a4e
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/mmc/host/mxcmmc.c

+ 1 - 1
drivers/mmc/host/mxcmmc.c

@@ -1075,7 +1075,7 @@ static int mxcmci_probe(struct platform_device *pdev)
 		dat3_card_detect = true;
 		dat3_card_detect = true;
 
 
 	ret = mmc_regulator_get_supply(mmc);
 	ret = mmc_regulator_get_supply(mmc);
-	if (ret == -EPROBE_DEFER)
+	if (ret)
 		goto out_free;
 		goto out_free;
 
 
 	if (!mmc->ocr_avail) {
 	if (!mmc->ocr_avail) {