Jelajahi Sumber

s390/cio: invalidate cdev pointer before deregistration

Make sure that the cdev pointer for IO subchannels is set to NULL when
we deregister the device (and release its last reference). This will
fix a bug were another process operates on an already freed ccw device.

Acked-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Sebastian Ott 13 tahun lalu
induk
melakukan
3368ba25bf
1 mengubah file dengan 4 tambahan dan 1 penghapusan
  1. 4 1
      drivers/s390/cio/device.c

+ 4 - 1
drivers/s390/cio/device.c

@@ -1521,11 +1521,14 @@ static int io_subchannel_sch_event(struct subchannel *sch, int process)
 			goto out;
 			goto out;
 		break;
 		break;
 	case IO_SCH_UNREG_ATTACH:
 	case IO_SCH_UNREG_ATTACH:
+		spin_lock_irqsave(sch->lock, flags);
 		if (cdev->private->flags.resuming) {
 		if (cdev->private->flags.resuming) {
 			/* Device will be handled later. */
 			/* Device will be handled later. */
 			rc = 0;
 			rc = 0;
-			goto out;
+			goto out_unlock;
 		}
 		}
+		sch_set_cdev(sch, NULL);
+		spin_unlock_irqrestore(sch->lock, flags);
 		/* Unregister ccw device. */
 		/* Unregister ccw device. */
 		ccw_device_unregister(cdev);
 		ccw_device_unregister(cdev);
 		break;
 		break;