Преглед изворни кода

regmap: regcache-rbtree: Fix present bitmap resize

When inserting a new register into a block at the lower end the present
bitmap is currently shifted into the wrong direction. The effect of this is
that the bitmap becomes corrupted and registers which are present might be
reported as not present and vice versa.

Fix this by shifting left rather than right.

Fixes: 472fdec7380c("regmap: rbtree: Reduce number of nodes, take 2")
Reported-by: Daniel Baluta <daniel.baluta@gmail.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Lars-Peter Clausen пре 10 година
родитељ
комит
328f494d95
1 измењених фајлова са 1 додато и 1 уклоњено
  1. 1 1
      drivers/base/regmap/regcache-rbtree.c

+ 1 - 1
drivers/base/regmap/regcache-rbtree.c

@@ -307,7 +307,7 @@ static int regcache_rbtree_insert_to_block(struct regmap *map,
 	if (pos == 0) {
 	if (pos == 0) {
 		memmove(blk + offset * map->cache_word_size,
 		memmove(blk + offset * map->cache_word_size,
 			blk, rbnode->blklen * map->cache_word_size);
 			blk, rbnode->blklen * map->cache_word_size);
-		bitmap_shift_right(present, present, offset, blklen);
+		bitmap_shift_left(present, present, offset, blklen);
 	}
 	}
 
 
 	/* update the rbnode block, its size and the base register */
 	/* update the rbnode block, its size and the base register */