浏览代码

[media] staging: lirc: freeing ERR_PTRs

We call kfree(data_buf) in the error handling and that will oops if this
is an error pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Dan Carpenter 11 年之前
父节点
当前提交
3232e04df7
共有 2 个文件被更改,包括 2 次插入0 次删除
  1. 1 0
      drivers/staging/media/lirc/lirc_imon.c
  2. 1 0
      drivers/staging/media/lirc/lirc_sasem.c

+ 1 - 0
drivers/staging/media/lirc/lirc_imon.c

@@ -414,6 +414,7 @@ static ssize_t vfd_write(struct file *file, const char __user *buf,
 	data_buf = memdup_user(buf, n_bytes);
 	if (IS_ERR(data_buf)) {
 		retval = PTR_ERR(data_buf);
+		data_buf = NULL;
 		goto exit;
 	}
 

+ 1 - 0
drivers/staging/media/lirc/lirc_sasem.c

@@ -392,6 +392,7 @@ static ssize_t vfd_write(struct file *file, const char __user *buf,
 	data_buf = memdup_user((void const __user *)buf, n_bytes);
 	if (IS_ERR(data_buf)) {
 		retval = PTR_ERR(data_buf);
+		data_buf = NULL;
 		goto exit;
 	}