Browse Source

Revert "Input: zforce - don't overwrite the stack"

This reverts commit 7d01cd261c76f95913c81554a751968a1d282d3a because
with given FRAME_MAXSIZE of 257 the check will never trigger and it
causes warnings from GCC (with -Wtype-limits). Also the check was
incorrect as it was not accounting for the already read 2 bytes of data
stored in the buffer.
Dmitry Torokhov 10 năm trước cách đây
mục cha
commit
3213afb8bf
1 tập tin đã thay đổi với 1 bổ sung1 xóa
  1. 1 1
      drivers/input/touchscreen/zforce_ts.c

+ 1 - 1
drivers/input/touchscreen/zforce_ts.c

@@ -429,7 +429,7 @@ static int zforce_read_packet(struct zforce_ts *ts, u8 *buf)
 		goto unlock;
 	}
 
-	if (buf[PAYLOAD_LENGTH] == 0 || buf[PAYLOAD_LENGTH] > FRAME_MAXSIZE) {
+	if (buf[PAYLOAD_LENGTH] == 0) {
 		dev_err(&client->dev, "invalid payload length: %d\n",
 			buf[PAYLOAD_LENGTH]);
 		ret = -EIO;