Эх сурвалжийг харах

f2fs: reduce covered region of sbi->cp_rwsem in f2fs_map_blocks

Only cover sbi->cp_rwsem on one dnode page's allocation and modification
instead of multiple's in f2fs_map_blocks, it can reduce the covered region
of cp_rwsem, then we can avoid potential long time delay for concurrent
checkpointer.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Chao Yu 9 жил өмнө
parent
commit
3104af35eb
1 өөрчлөгдсөн 7 нэмэгдсэн , 2 устгасан
  1. 7 2
      fs/f2fs/data.c

+ 7 - 2
fs/f2fs/data.c

@@ -590,7 +590,7 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map,
 	}
 	}
 
 
 	if (create)
 	if (create)
-		f2fs_lock_op(F2FS_I_SB(inode));
+		f2fs_lock_op(sbi);
 
 
 	/* When reading holes, we need its node page */
 	/* When reading holes, we need its node page */
 	set_new_dnode(&dn, inode, NULL, NULL, 0);
 	set_new_dnode(&dn, inode, NULL, NULL, 0);
@@ -647,6 +647,11 @@ get_next:
 		allocated = false;
 		allocated = false;
 		f2fs_put_dnode(&dn);
 		f2fs_put_dnode(&dn);
 
 
+		if (create) {
+			f2fs_unlock_op(sbi);
+			f2fs_lock_op(sbi);
+		}
+
 		set_new_dnode(&dn, inode, NULL, NULL, 0);
 		set_new_dnode(&dn, inode, NULL, NULL, 0);
 		err = get_dnode_of_data(&dn, pgofs, mode);
 		err = get_dnode_of_data(&dn, pgofs, mode);
 		if (err) {
 		if (err) {
@@ -702,7 +707,7 @@ put_out:
 	f2fs_put_dnode(&dn);
 	f2fs_put_dnode(&dn);
 unlock_out:
 unlock_out:
 	if (create)
 	if (create)
-		f2fs_unlock_op(F2FS_I_SB(inode));
+		f2fs_unlock_op(sbi);
 out:
 out:
 	trace_f2fs_map_blocks(inode, map, err);
 	trace_f2fs_map_blocks(inode, map, err);
 	return err;
 	return err;