浏览代码

staging: lustre: checking for NULL instead of IS_ERR

lustre_cfg_new() returns error pointers on error, it never returns NULL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter 9 年之前
父节点
当前提交
3092c34a4a
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/staging/lustre/lustre/mgc/mgc_request.c

+ 1 - 1
drivers/staging/lustre/lustre/mgc/mgc_request.c

@@ -1282,7 +1282,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
 
 
 		rc = -ENOMEM;
 		rc = -ENOMEM;
 		lcfg = lustre_cfg_new(LCFG_PARAM, &bufs);
 		lcfg = lustre_cfg_new(LCFG_PARAM, &bufs);
-		if (!lcfg) {
+		if (IS_ERR(lcfg)) {
 			CERROR("mgc: cannot allocate memory\n");
 			CERROR("mgc: cannot allocate memory\n");
 			break;
 			break;
 		}
 		}