Эх сурвалжийг харах

staging: unisys: visorbus: Check controlvm message payload size

Checks the controlvm message's payload size before copying it into a
parser_context struct's name region.

Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Binder 8 жил өмнө
parent
commit
308ee8aa1f

+ 4 - 0
drivers/staging/unisys/visorbus/visorchipset.c

@@ -399,6 +399,10 @@ parser_name_get(struct parser_context *ctx)
 	struct spar_controlvm_parameters_header *phdr = NULL;
 	struct spar_controlvm_parameters_header *phdr = NULL;
 
 
 	phdr = (struct spar_controlvm_parameters_header *)(ctx->data);
 	phdr = (struct spar_controlvm_parameters_header *)(ctx->data);
+
+	if (phdr->name_offset + phdr->name_length > ctx->param_bytes)
+		return NULL;
+
 	ctx->curr = ctx->data + phdr->name_offset;
 	ctx->curr = ctx->data + phdr->name_offset;
 	ctx->bytes_remaining = phdr->name_length;
 	ctx->bytes_remaining = phdr->name_length;
 	return parser_string_get(ctx);
 	return parser_string_get(ctx);