소스 검색

mm, dev_pagemap: Do not clear ->mapping on final put

MEMORY_DEVICE_FS_DAX relies on typical page semantics whereby ->mapping
is only ever cleared by truncation, not final put.

Without this fix dax pages may forget their mapping association at the
end of every page pin event.

Move this atypical behavior that HMM wants into the HMM ->page_free()
callback.

Cc: <stable@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Fixes: d2c997c0f145 ("fs, dax: use page->mapping...")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Dan Williams 7 년 전
부모
커밋
2fa147bdbf
2개의 변경된 파일2개의 추가작업 그리고 1개의 파일을 삭제
  1. 0 1
      kernel/memremap.c
  2. 2 0
      mm/hmm.c

+ 0 - 1
kernel/memremap.c

@@ -339,7 +339,6 @@ void __put_devmap_managed_page(struct page *page)
 		__ClearPageActive(page);
 		__ClearPageActive(page);
 		__ClearPageWaiters(page);
 		__ClearPageWaiters(page);
 
 
-		page->mapping = NULL;
 		mem_cgroup_uncharge(page);
 		mem_cgroup_uncharge(page);
 
 
 		page->pgmap->page_free(page, page->pgmap->data);
 		page->pgmap->page_free(page, page->pgmap->data);

+ 2 - 0
mm/hmm.c

@@ -963,6 +963,8 @@ static void hmm_devmem_free(struct page *page, void *data)
 {
 {
 	struct hmm_devmem *devmem = data;
 	struct hmm_devmem *devmem = data;
 
 
+	page->mapping = NULL;
+
 	devmem->ops->free(devmem, page);
 	devmem->ops->free(devmem, page);
 }
 }