Просмотр исходного кода

genetlink: remove superfluous assignment

the local variable ops and n_ops were just read out from family,
and not changed, hence no need to assign back.

Validation functions should operate on const parameters and not
change anything.

Signed-off-by: Cheng Renquan <crquan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Denis ChengRq 11 лет назад
Родитель
Сommit
2f91abd451
1 измененных файлов с 1 добавлено и 5 удалено
  1. 1 5
      net/netlink/genetlink.c

+ 1 - 5
net/netlink/genetlink.c

@@ -317,7 +317,7 @@ static void genl_unregister_mc_groups(struct genl_family *family)
 	}
 	}
 }
 }
 
 
-static int genl_validate_ops(struct genl_family *family)
+static int genl_validate_ops(const struct genl_family *family)
 {
 {
 	const struct genl_ops *ops = family->ops;
 	const struct genl_ops *ops = family->ops;
 	unsigned int n_ops = family->n_ops;
 	unsigned int n_ops = family->n_ops;
@@ -337,10 +337,6 @@ static int genl_validate_ops(struct genl_family *family)
 				return -EINVAL;
 				return -EINVAL;
 	}
 	}
 
 
-	/* family is not registered yet, so no locking needed */
-	family->ops = ops;
-	family->n_ops = n_ops;
-
 	return 0;
 	return 0;
 }
 }