Browse Source

char: tpm: Deletion of unnecessary checks before the function call "tpm_dev_vendor_release"

The tpm_dev_vendor_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Markus Elfring 10 years ago
parent
commit
2dfc2deda2
2 changed files with 2 additions and 4 deletions
  1. 1 2
      drivers/char/tpm/tpm_i2c_atmel.c
  2. 1 2
      drivers/char/tpm/tpm_i2c_nuvoton.c

+ 1 - 2
drivers/char/tpm/tpm_i2c_atmel.c

@@ -206,8 +206,7 @@ static int i2c_atmel_remove(struct i2c_client *client)
 	struct device *dev = &(client->dev);
 	struct device *dev = &(client->dev);
 	struct tpm_chip *chip = dev_get_drvdata(dev);
 	struct tpm_chip *chip = dev_get_drvdata(dev);
 
 
-	if (chip)
-		tpm_dev_vendor_release(chip);
+	tpm_dev_vendor_release(chip);
 	tpm_remove_hardware(dev);
 	tpm_remove_hardware(dev);
 	kfree(chip);
 	kfree(chip);
 	return 0;
 	return 0;

+ 1 - 2
drivers/char/tpm/tpm_i2c_nuvoton.c

@@ -630,8 +630,7 @@ static int i2c_nuvoton_remove(struct i2c_client *client)
 	struct device *dev = &(client->dev);
 	struct device *dev = &(client->dev);
 	struct tpm_chip *chip = dev_get_drvdata(dev);
 	struct tpm_chip *chip = dev_get_drvdata(dev);
 
 
-	if (chip)
-		tpm_dev_vendor_release(chip);
+	tpm_dev_vendor_release(chip);
 	tpm_remove_hardware(dev);
 	tpm_remove_hardware(dev);
 	kfree(chip);
 	kfree(chip);
 	return 0;
 	return 0;