Browse Source

kvm: x86: i8259: return initialized data on invalid-size read

If data is read from PIC with invalid access size, the return data stays
uninitialized even though success is returned.

Fix this by always initializing the data.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Nadav Amit <nadav.amit@gmail.com>
Message-Id: <20150311111609.GG8544@dhcp-25-225.brq.redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Petr Matousek 10 years ago
parent
commit
2dccb4cdbf
1 changed files with 1 additions and 0 deletions
  1. 1 0
      arch/x86/kvm/i8259.c

+ 1 - 0
arch/x86/kvm/i8259.c

@@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s,
 		return -EOPNOTSUPP;
 		return -EOPNOTSUPP;
 
 
 	if (len != 1) {
 	if (len != 1) {
+		memset(val, 0, len);
 		pr_pic_unimpl("non byte read\n");
 		pr_pic_unimpl("non byte read\n");
 		return 0;
 		return 0;
 	}
 	}