浏览代码

nvmet: avoid dereferencing nvmet_req

No need to dereference req twice to get the cmd when we already
have it stored in a local variable.

Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
Max Gurtovoy 8 年之前
父节点
当前提交
2dbf5816bb
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      drivers/nvme/target/fabrics-cmd.c

+ 1 - 1
drivers/nvme/target/fabrics-cmd.c

@@ -220,7 +220,7 @@ int nvmet_parse_connect_cmd(struct nvmet_req *req)
 
 
 	req->ns = NULL;
 	req->ns = NULL;
 
 
-	if (req->cmd->common.opcode != nvme_fabrics_command) {
+	if (cmd->common.opcode != nvme_fabrics_command) {
 		pr_err("invalid command 0x%x on unconnected queue.\n",
 		pr_err("invalid command 0x%x on unconnected queue.\n",
 			cmd->fabrics.opcode);
 			cmd->fabrics.opcode);
 		return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
 		return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;