Browse Source

net: sched: cls_matchall: fix null pointer dereference

Since the head is guaranteed by the check above to be null, the call_rcu
would explode. Remove the previously logically dead code that was made
logically very much alive and kicking.

Fixes: 985538eee06f ("net/sched: remove redundant null check on head")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Jiri Pirko 8 years ago
parent
commit
2d76b2f8b5
1 changed files with 0 additions and 1 deletions
  1. 0 1
      net/sched/cls_matchall.c

+ 0 - 1
net/sched/cls_matchall.c

@@ -203,7 +203,6 @@ static int mall_change(struct net *net, struct sk_buff *in_skb,
 
 
 	*arg = (unsigned long) head;
 	*arg = (unsigned long) head;
 	rcu_assign_pointer(tp->root, new);
 	rcu_assign_pointer(tp->root, new);
-	call_rcu(&head->rcu, mall_destroy_rcu);
 	return 0;
 	return 0;
 
 
 err_replace_hw_filter:
 err_replace_hw_filter: