|
@@ -157,18 +157,14 @@ int ptlrpc_set_import_discon(struct obd_import *imp, __u32 conn_cnt)
|
|
|
&target_start, &target_len);
|
|
|
|
|
|
if (imp->imp_replayable) {
|
|
|
- LCONSOLE_WARN("%s: Connection to %.*s (at %s) was "
|
|
|
- "lost; in progress operations using this "
|
|
|
- "service will wait for recovery to complete\n",
|
|
|
- imp->imp_obd->obd_name, target_len, target_start,
|
|
|
- libcfs_nid2str(imp->imp_connection->c_peer.nid));
|
|
|
+ LCONSOLE_WARN("%s: Connection to %.*s (at %s) was lost; in progress operations using this service will wait for recovery to complete\n",
|
|
|
+ imp->imp_obd->obd_name, target_len, target_start,
|
|
|
+ libcfs_nid2str(imp->imp_connection->c_peer.nid));
|
|
|
} else {
|
|
|
- LCONSOLE_ERROR_MSG(0x166, "%s: Connection to "
|
|
|
- "%.*s (at %s) was lost; in progress "
|
|
|
- "operations using this service will fail\n",
|
|
|
- imp->imp_obd->obd_name,
|
|
|
- target_len, target_start,
|
|
|
- libcfs_nid2str(imp->imp_connection->c_peer.nid));
|
|
|
+ LCONSOLE_ERROR_MSG(0x166, "%s: Connection to %.*s (at %s) was lost; in progress operations using this service will fail\n",
|
|
|
+ imp->imp_obd->obd_name,
|
|
|
+ target_len, target_start,
|
|
|
+ libcfs_nid2str(imp->imp_connection->c_peer.nid));
|
|
|
}
|
|
|
IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_DISCON);
|
|
|
spin_unlock(&imp->imp_lock);
|
|
@@ -328,8 +324,8 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
|
|
|
* sluggish nets). Let's check this. If there
|
|
|
* is no inflight and unregistering != 0, this
|
|
|
* is bug. */
|
|
|
- LASSERTF(count == 0, "Some RPCs are still "
|
|
|
- "unregistering: %d\n", count);
|
|
|
+ LASSERTF(count == 0, "Some RPCs are still unregistering: %d\n",
|
|
|
+ count);
|
|
|
|
|
|
/* Let's save one loop as soon as inflight have
|
|
|
* dropped to zero. No new inflights possible at
|
|
@@ -353,12 +349,11 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
|
|
|
"still on delayed list");
|
|
|
}
|
|
|
|
|
|
- CERROR("%s: RPCs in \"%s\" phase found (%d). "
|
|
|
- "Network is sluggish? Waiting them "
|
|
|
- "to error out.\n", cli_tgt,
|
|
|
+ CERROR("%s: RPCs in \"%s\" phase found (%d). Network is sluggish? Waiting them to error out.\n",
|
|
|
+ cli_tgt,
|
|
|
ptlrpc_phase2str(RQ_PHASE_UNREGISTERING),
|
|
|
atomic_read(&imp->
|
|
|
- imp_unregistering));
|
|
|
+ imp_unregistering));
|
|
|
}
|
|
|
spin_unlock(&imp->imp_lock);
|
|
|
}
|
|
@@ -413,8 +408,7 @@ void ptlrpc_fail_import(struct obd_import *imp, __u32 conn_cnt)
|
|
|
|
|
|
if (ptlrpc_set_import_discon(imp, conn_cnt)) {
|
|
|
if (!imp->imp_replayable) {
|
|
|
- CDEBUG(D_HA, "import %s@%s for %s not replayable, "
|
|
|
- "auto-deactivating\n",
|
|
|
+ CDEBUG(D_HA, "import %s@%s for %s not replayable, auto-deactivating\n",
|
|
|
obd2cli_tgt(imp->imp_obd),
|
|
|
imp->imp_connection->c_remote_uuid.uuid,
|
|
|
imp->imp_obd->obd_name);
|
|
@@ -541,8 +535,8 @@ static int import_select_connection(struct obd_import *imp)
|
|
|
at_reset(at, CONNECTION_SWITCH_MAX);
|
|
|
}
|
|
|
LASSERT(imp_conn->oic_last_attempt);
|
|
|
- CDEBUG(D_HA, "%s: tried all connections, increasing latency "
|
|
|
- "to %ds\n", imp->imp_obd->obd_name, at_get(at));
|
|
|
+ CDEBUG(D_HA, "%s: tried all connections, increasing latency to %ds\n",
|
|
|
+ imp->imp_obd->obd_name, at_get(at));
|
|
|
}
|
|
|
|
|
|
imp_conn->oic_last_attempt = cfs_time_current_64();
|
|
@@ -564,8 +558,7 @@ static int import_select_connection(struct obd_import *imp)
|
|
|
deuuidify(obd2cli_tgt(imp->imp_obd), NULL,
|
|
|
&target_start, &target_len);
|
|
|
|
|
|
- CDEBUG(D_HA, "%s: Connection changing to"
|
|
|
- " %.*s (at %s)\n",
|
|
|
+ CDEBUG(D_HA, "%s: Connection changing to %.*s (at %s)\n",
|
|
|
imp->imp_obd->obd_name,
|
|
|
target_len, target_start,
|
|
|
libcfs_nid2str(imp_conn->oic_conn->c_peer.nid));
|
|
@@ -935,14 +928,13 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
|
|
|
lustre_msg_get_handle(
|
|
|
request->rq_repmsg)->cookie);
|
|
|
} else {
|
|
|
- LCONSOLE_WARN("Evicted from %s (at %s) "
|
|
|
- "after server handle changed from %#llx to %#llx\n",
|
|
|
+ LCONSOLE_WARN("Evicted from %s (at %s) after server handle changed from %#llx to %#llx\n",
|
|
|
obd2cli_tgt(imp->imp_obd),
|
|
|
imp->imp_connection-> \
|
|
|
c_remote_uuid.uuid,
|
|
|
imp->imp_remote_handle.cookie,
|
|
|
lustre_msg_get_handle(
|
|
|
- request->rq_repmsg)->cookie);
|
|
|
+ request->rq_repmsg)->cookie);
|
|
|
}
|
|
|
|
|
|
|
|
@@ -962,8 +954,8 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
|
|
|
}
|
|
|
|
|
|
if (imp->imp_invalid) {
|
|
|
- CDEBUG(D_HA, "%s: reconnected but import is invalid; "
|
|
|
- "marking evicted\n", imp->imp_obd->obd_name);
|
|
|
+ CDEBUG(D_HA, "%s: reconnected but import is invalid; marking evicted\n",
|
|
|
+ imp->imp_obd->obd_name);
|
|
|
IMPORT_SET_STATE(imp, LUSTRE_IMP_EVICTED);
|
|
|
} else if (MSG_CONNECT_RECOVERING & msg_flags) {
|
|
|
CDEBUG(D_HA, "%s: reconnected to %s during replay\n",
|
|
@@ -985,8 +977,8 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
|
|
|
imp->imp_last_replay_transno = 0;
|
|
|
IMPORT_SET_STATE(imp, LUSTRE_IMP_REPLAY);
|
|
|
} else {
|
|
|
- DEBUG_REQ(D_HA, request, "%s: evicting (reconnect/recover flags"
|
|
|
- " not set: %x)", imp->imp_obd->obd_name, msg_flags);
|
|
|
+ DEBUG_REQ(D_HA, request, "%s: evicting (reconnect/recover flags not set: %x)",
|
|
|
+ imp->imp_obd->obd_name, msg_flags);
|
|
|
imp->imp_remote_handle =
|
|
|
*lustre_msg_get_handle(request->rq_repmsg);
|
|
|
IMPORT_SET_STATE(imp, LUSTRE_IMP_EVICTED);
|
|
@@ -994,17 +986,13 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
|
|
|
|
|
|
/* Sanity checks for a reconnected import. */
|
|
|
if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE)) {
|
|
|
- CERROR("imp_replayable flag does not match server "
|
|
|
- "after reconnect. We should LBUG right here.\n");
|
|
|
+ CERROR("imp_replayable flag does not match server after reconnect. We should LBUG right here.\n");
|
|
|
}
|
|
|
|
|
|
if (lustre_msg_get_last_committed(request->rq_repmsg) > 0 &&
|
|
|
lustre_msg_get_last_committed(request->rq_repmsg) <
|
|
|
aa->pcaa_peer_committed) {
|
|
|
- CERROR("%s went back in time (transno %lld"
|
|
|
- " was previously committed, server now claims %lld"
|
|
|
- ")! See https://bugzilla.lustre.org/show_bug.cgi?"
|
|
|
- "id=9646\n",
|
|
|
+ CERROR("%s went back in time (transno %lld was previously committed, server now claims %lld)! See https://bugzilla.lustre.org/show_bug.cgi?id=9646\n",
|
|
|
obd2cli_tgt(imp->imp_obd), aa->pcaa_peer_committed,
|
|
|
lustre_msg_get_last_committed(request->rq_repmsg));
|
|
|
}
|
|
@@ -1013,8 +1001,7 @@ finish:
|
|
|
rc = ptlrpc_import_recovery_state_machine(imp);
|
|
|
if (rc != 0) {
|
|
|
if (rc == -ENOTCONN) {
|
|
|
- CDEBUG(D_HA, "evicted/aborted by %s@%s during recovery;"
|
|
|
- "invalidating and reconnecting\n",
|
|
|
+ CDEBUG(D_HA, "evicted/aborted by %s@%s during recovery; invalidating and reconnecting\n",
|
|
|
obd2cli_tgt(imp->imp_obd),
|
|
|
imp->imp_connection->c_remote_uuid.uuid);
|
|
|
ptlrpc_connect_import(imp);
|
|
@@ -1034,9 +1021,7 @@ finish:
|
|
|
|
|
|
if ((imp->imp_connect_flags_orig & OBD_CONNECT_IBITS) &&
|
|
|
!(ocd->ocd_connect_flags & OBD_CONNECT_IBITS)) {
|
|
|
- LCONSOLE_WARN("%s: MDS %s does not support ibits "
|
|
|
- "lock, either very old or invalid: "
|
|
|
- "requested %llx, replied %llx\n",
|
|
|
+ LCONSOLE_WARN("%s: MDS %s does not support ibits lock, either very old or invalid: requested %llx, replied %llx\n",
|
|
|
imp->imp_obd->obd_name,
|
|
|
imp->imp_connection->c_remote_uuid.uuid,
|
|
|
imp->imp_connect_flags_orig,
|
|
@@ -1052,13 +1037,12 @@ finish:
|
|
|
LUSTRE_VERSION_OFFSET_WARN)) {
|
|
|
/* Sigh, some compilers do not like #ifdef in the middle
|
|
|
of macro arguments */
|
|
|
- const char *older = "older. Consider upgrading server "
|
|
|
- "or downgrading client";
|
|
|
- const char *newer = "newer than client version. "
|
|
|
- "Consider upgrading client";
|
|
|
+ const char *older = "older. Consider upgrading server or downgrading client"
|
|
|
+ ;
|
|
|
+ const char *newer = "newer than client version. Consider upgrading client"
|
|
|
+ ;
|
|
|
|
|
|
- LCONSOLE_WARN("Server %s version (%d.%d.%d.%d) "
|
|
|
- "is much %s (%s)\n",
|
|
|
+ LCONSOLE_WARN("Server %s version (%d.%d.%d.%d) is much %s (%s)\n",
|
|
|
obd2cli_tgt(imp->imp_obd),
|
|
|
OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
|
|
|
OBD_OCD_VERSION_MINOR(ocd->ocd_version),
|
|
@@ -1095,10 +1079,7 @@ finish:
|
|
|
* the checksum types it doesn't support */
|
|
|
if ((ocd->ocd_cksum_types &
|
|
|
cksum_types_supported_client()) == 0) {
|
|
|
- LCONSOLE_WARN("The negotiation of the checksum "
|
|
|
- "algorithm to use with server %s "
|
|
|
- "failed (%x/%x), disabling "
|
|
|
- "checksums\n",
|
|
|
+ LCONSOLE_WARN("The negotiation of the checksum algorithm to use with server %s failed (%x/%x), disabling checksums\n",
|
|
|
obd2cli_tgt(imp->imp_obd),
|
|
|
ocd->ocd_cksum_types,
|
|
|
cksum_types_supported_client());
|
|
@@ -1191,17 +1172,13 @@ out:
|
|
|
* connection from liblustre clients, so we
|
|
|
* should never see this from VFS context
|
|
|
*/
|
|
|
- LCONSOLE_ERROR_MSG(0x16a, "Server %s version "
|
|
|
- "(%d.%d.%d.%d)"
|
|
|
- " refused connection from this client "
|
|
|
- "with an incompatible version (%s). "
|
|
|
- "Client must be recompiled\n",
|
|
|
- obd2cli_tgt(imp->imp_obd),
|
|
|
- OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
|
|
|
- OBD_OCD_VERSION_MINOR(ocd->ocd_version),
|
|
|
- OBD_OCD_VERSION_PATCH(ocd->ocd_version),
|
|
|
- OBD_OCD_VERSION_FIX(ocd->ocd_version),
|
|
|
- LUSTRE_VERSION_STRING);
|
|
|
+ LCONSOLE_ERROR_MSG(0x16a, "Server %s version (%d.%d.%d.%d) refused connection from this client with an incompatible version (%s). Client must be recompiled\n",
|
|
|
+ obd2cli_tgt(imp->imp_obd),
|
|
|
+ OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
|
|
|
+ OBD_OCD_VERSION_MINOR(ocd->ocd_version),
|
|
|
+ OBD_OCD_VERSION_PATCH(ocd->ocd_version),
|
|
|
+ OBD_OCD_VERSION_FIX(ocd->ocd_version),
|
|
|
+ LUSTRE_VERSION_STRING);
|
|
|
ptlrpc_deactivate_import(imp);
|
|
|
IMPORT_SET_STATE(imp, LUSTRE_IMP_CLOSED);
|
|
|
}
|
|
@@ -1237,8 +1214,7 @@ static int completed_replay_interpret(const struct lu_env *env,
|
|
|
"%s: version recovery fails, reconnecting\n",
|
|
|
req->rq_import->imp_obd->obd_name);
|
|
|
} else {
|
|
|
- CDEBUG(D_HA, "%s: LAST_REPLAY message error: %d, "
|
|
|
- "reconnecting\n",
|
|
|
+ CDEBUG(D_HA, "%s: LAST_REPLAY message error: %d, reconnecting\n",
|
|
|
req->rq_import->imp_obd->obd_name,
|
|
|
req->rq_status);
|
|
|
}
|
|
@@ -1343,9 +1319,7 @@ int ptlrpc_import_recovery_state_machine(struct obd_import *imp)
|
|
|
/* Don't care about MGC eviction */
|
|
|
if (strcmp(imp->imp_obd->obd_type->typ_name,
|
|
|
LUSTRE_MGC_NAME) != 0) {
|
|
|
- LCONSOLE_ERROR_MSG(0x167, "%s: This client was evicted "
|
|
|
- "by %.*s; in progress operations "
|
|
|
- "using this service will fail.\n",
|
|
|
+ LCONSOLE_ERROR_MSG(0x167, "%s: This client was evicted by %.*s; in progress operations using this service will fail.\n",
|
|
|
imp->imp_obd->obd_name, target_len,
|
|
|
target_start);
|
|
|
}
|
|
@@ -1455,8 +1429,7 @@ int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
|
|
|
break;
|
|
|
default:
|
|
|
rc = -EINVAL;
|
|
|
- CERROR("%s: don't know how to disconnect from %s "
|
|
|
- "(connect_op %d): rc = %d\n",
|
|
|
+ CERROR("%s: don't know how to disconnect from %s (connect_op %d): rc = %d\n",
|
|
|
imp->imp_obd->obd_name, obd2cli_tgt(imp->imp_obd),
|
|
|
imp->imp_connect_op, rc);
|
|
|
return rc;
|
|
@@ -1607,8 +1580,8 @@ int at_measured(struct adaptive_timeout *at, unsigned int val)
|
|
|
at->at_current = max(at->at_current, at_min);
|
|
|
|
|
|
if (at->at_current != old)
|
|
|
- CDEBUG(D_OTHER, "AT %p change: old=%u new=%u delta=%d "
|
|
|
- "(val=%u) hist %u %u %u %u\n", at,
|
|
|
+ CDEBUG(D_OTHER, "AT %p change: old=%u new=%u delta=%d (val=%u) hist %u %u %u %u\n",
|
|
|
+ at,
|
|
|
old, at->at_current, at->at_current - old, val,
|
|
|
at->at_hist[0], at->at_hist[1], at->at_hist[2],
|
|
|
at->at_hist[3]);
|