浏览代码

s390/tape: Use memdup_user() rather than duplicating its implementation

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Markus Elfring 9 年之前
父节点
当前提交
2ccb5bf0e2
共有 1 个文件被更改,包括 3 次插入8 次删除
  1. 3 8
      drivers/s390/char/tape_3590.c

+ 3 - 8
drivers/s390/char/tape_3590.c

@@ -312,15 +312,10 @@ static int tape_3592_ioctl_kekl_set(struct tape_device *device,
 		return -ENOSYS;
 		return -ENOSYS;
 	if (!crypt_enabled(device))
 	if (!crypt_enabled(device))
 		return -EUNATCH;
 		return -EUNATCH;
-	ext_kekls = kmalloc(sizeof(*ext_kekls), GFP_KERNEL);
-	if (!ext_kekls)
-		return -ENOMEM;
-	if (copy_from_user(ext_kekls, (char __user *)arg, sizeof(*ext_kekls))) {
-		rc = -EFAULT;
-		goto out;
-	}
+	ext_kekls = memdup_user((char __user *)arg, sizeof(*ext_kekls));
+	if (IS_ERR(ext_kekls))
+		return PTR_ERR(ext_kekls);
 	rc = tape_3592_kekl_set(device, ext_kekls);
 	rc = tape_3592_kekl_set(device, ext_kekls);
-out:
 	kfree(ext_kekls);
 	kfree(ext_kekls);
 	return rc;
 	return rc;
 }
 }