Browse Source

cuse: fix memory leak

The problem is that fuse_dev_alloc() acquires an extra reference to cc.fc,
and the original ref count is never dropped.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Fixes: cc080e9e9be1 ("fuse: introduce per-instance fuse_dev structure")
Cc: <stable@vger.kernel.org> # v4.2+
Miklos Szeredi 9 years ago
parent
commit
2c5816b4be
1 changed files with 2 additions and 0 deletions
  1. 2 0
      fs/fuse/cuse.c

+ 2 - 0
fs/fuse/cuse.c

@@ -549,6 +549,8 @@ static int cuse_channel_release(struct inode *inode, struct file *file)
 		unregister_chrdev_region(cc->cdev->dev, 1);
 		unregister_chrdev_region(cc->cdev->dev, 1);
 		cdev_del(cc->cdev);
 		cdev_del(cc->cdev);
 	}
 	}
+	/* Base reference is now owned by "fud" */
+	fuse_conn_put(&cc->fc);
 
 
 	rc = fuse_dev_release(inode, file);	/* puts the base reference */
 	rc = fuse_dev_release(inode, file);	/* puts the base reference */