Browse Source

MIPS: Make MIPS_CMDLINE_DTB default

Seval of-enabled machines (bmips, lantiq, xlp, pistachio, ralink) copied
the arguments from dtb to arcs_command_line to prevent the kernel from
overwriting them.

Since there is now an option to keep the dtb arguments, default to the
new option remove the "backup" to arcs_command_line in case of USE_OF is
enabled, except for those platforms that still take the bootloader
arguments or do not use any at all.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
Cc: linux-mips@linux-mips.org
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: Ganesan Ramalingam <ganesanr@broadcom.com>
Cc: Jayachandran C <jchandra@broadcom.com>
Cc: Andrew Bresticker <abrestic@chromium.org>
Cc: James Hartley <james.hartley@imgtec.com>
Patchwork: https://patchwork.linux-mips.org/patch/11285/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Jonas Gorski 9 years ago
parent
commit
2bcef9b457

+ 3 - 0
arch/mips/Kconfig

@@ -2751,6 +2751,9 @@ endchoice
 
 
 choice
 choice
 	prompt "Kernel command line type" if !CMDLINE_OVERRIDE
 	prompt "Kernel command line type" if !CMDLINE_OVERRIDE
+	default MIPS_CMDLINE_FROM_DTB if USE_OF && !ATH79 && !MACH_INGENIC && \
+					 !MIPS_MALTA && !MIPS_SEAD3 && \
+					 !CAVIUM_OCTEON_SOC
 	default MIPS_CMDLINE_FROM_BOOTLOADER
 	default MIPS_CMDLINE_FROM_BOOTLOADER
 
 
 	config MIPS_CMDLINE_FROM_DTB
 	config MIPS_CMDLINE_FROM_DTB

+ 0 - 1
arch/mips/bmips/setup.c

@@ -157,7 +157,6 @@ void __init plat_mem_setup(void)
 		panic("no dtb found");
 		panic("no dtb found");
 
 
 	__dt_setup_arch(dtb);
 	__dt_setup_arch(dtb);
-	strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
 
 
 	for (q = bmips_quirk_list; q->quirk_fn; q++) {
 	for (q = bmips_quirk_list; q->quirk_fn; q++) {
 		if (of_flat_dt_is_compatible(of_get_flat_dt_root(),
 		if (of_flat_dt_is_compatible(of_get_flat_dt_root(),

+ 0 - 2
arch/mips/lantiq/prom.c

@@ -77,8 +77,6 @@ void __init plat_mem_setup(void)
 	 * parsed resulting in our memory appearing
 	 * parsed resulting in our memory appearing
 	 */
 	 */
 	__dt_setup_arch(__dtb_start);
 	__dt_setup_arch(__dtb_start);
-
-	strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
 }
 }
 
 
 void __init device_tree_init(void)
 void __init device_tree_init(void)

+ 0 - 1
arch/mips/netlogic/xlp/dt.c

@@ -87,7 +87,6 @@ void __init *xlp_dt_init(void *fdtp)
 void __init xlp_early_init_devtree(void)
 void __init xlp_early_init_devtree(void)
 {
 {
 	__dt_setup_arch(xlp_fdt_blob);
 	__dt_setup_arch(xlp_fdt_blob);
-	strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
 }
 }
 
 
 void __init device_tree_init(void)
 void __init device_tree_init(void)

+ 0 - 1
arch/mips/pistachio/init.c

@@ -58,7 +58,6 @@ void __init plat_mem_setup(void)
 		panic("Device-tree not present");
 		panic("Device-tree not present");
 
 
 	__dt_setup_arch((void *)fw_arg1);
 	__dt_setup_arch((void *)fw_arg1);
-	strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
 
 
 	plat_setup_iocoherency();
 	plat_setup_iocoherency();
 }
 }

+ 0 - 2
arch/mips/ralink/of.c

@@ -74,8 +74,6 @@ void __init plat_mem_setup(void)
 	 */
 	 */
 	__dt_setup_arch(__dtb_start);
 	__dt_setup_arch(__dtb_start);
 
 
-	strlcpy(arcs_cmdline, boot_command_line, COMMAND_LINE_SIZE);
-
 	of_scan_flat_dt(early_init_dt_find_memory, NULL);
 	of_scan_flat_dt(early_init_dt_find_memory, NULL);
 	if (memory_dtb)
 	if (memory_dtb)
 		of_scan_flat_dt(early_init_dt_scan_memory, NULL);
 		of_scan_flat_dt(early_init_dt_scan_memory, NULL);