devm_ioremap_resource returns ERR_PTR on error, not NULL. Fix the error checks in the driver. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
@@ -1009,9 +1009,9 @@ int hdmi4_core_init(struct platform_device *pdev, struct hdmi_core_data *core)
}
core->base = devm_ioremap_resource(&pdev->dev, res);
- if (!core->base) {
+ if (IS_ERR(core->base)) {
DSSERR("can't ioremap CORE\n");
- return -ENOMEM;
+ return PTR_ERR(core->base);
return 0;
@@ -913,9 +913,9 @@ int hdmi5_core_init(struct platform_device *pdev, struct hdmi_core_data *core)
DSSERR("can't ioremap HDMI core\n");
@@ -246,9 +246,9 @@ int hdmi_phy_init(struct platform_device *pdev, struct hdmi_phy_data *phy)
phy->base = devm_ioremap_resource(&pdev->dev, res);
- if (!phy->base) {
+ if (IS_ERR(phy->base)) {
DSSERR("can't ioremap TX PHY\n");
+ return PTR_ERR(phy->base);
@@ -282,9 +282,9 @@ int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *pll)
pll->base = devm_ioremap_resource(&pdev->dev, res);
- if (!pll->base) {
+ if (IS_ERR(pll->base)) {
DSSERR("can't ioremap PLLCTRL\n");
+ return PTR_ERR(pll->base);
@@ -249,9 +249,9 @@ int hdmi_wp_init(struct platform_device *pdev, struct hdmi_wp_data *wp)
wp->base = devm_ioremap_resource(&pdev->dev, res);
- if (!wp->base) {
+ if (IS_ERR(wp->base)) {
DSSERR("can't ioremap HDMI WP\n");
+ return PTR_ERR(wp->base);