Browse Source

b43/leds: Ensure NUL-termination of LED name string

strncpy might not NUL-terminate the string, if the name equals the buffer size.
Use strlcpy instead.

Signed-off-by: Michael Buesch <m@bues.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Michael Büsch 7 years ago
parent
commit
2aa650d195
1 changed files with 1 additions and 1 deletions
  1. 1 1
      drivers/net/wireless/broadcom/b43/leds.c

+ 1 - 1
drivers/net/wireless/broadcom/b43/leds.c

@@ -131,7 +131,7 @@ static int b43_register_led(struct b43_wldev *dev, struct b43_led *led,
 	led->wl = dev->wl;
 	led->index = led_index;
 	led->activelow = activelow;
-	strncpy(led->name, name, sizeof(led->name));
+	strlcpy(led->name, name, sizeof(led->name));
 	atomic_set(&led->state, 0);
 
 	led->led_dev.name = led->name;