Просмотр исходного кода

mISDN: l1oip_core: replace _manual_ swap with swap macro

Make use of the swap macro and remove unnecessary variables skb and cnt.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Gustavo A. R. Silva 7 лет назад
Родитель
Сommit
28e8c1914a
1 измененных файлов с 2 добавлено и 8 удалено
  1. 2 8
      drivers/isdn/mISDN/l1oip_core.c

+ 2 - 8
drivers/isdn/mISDN/l1oip_core.c

@@ -440,14 +440,8 @@ l1oip_socket_recv(struct l1oip *hc, u8 remotecodec, u8 channel, u16 timebase,
 
 
 #ifdef REORDER_DEBUG
 #ifdef REORDER_DEBUG
 		if (hc->chan[channel].disorder_flag) {
 		if (hc->chan[channel].disorder_flag) {
-			struct sk_buff *skb;
-			int cnt;
-			skb = hc->chan[channel].disorder_skb;
-			hc->chan[channel].disorder_skb = nskb;
-			nskb = skb;
-			cnt = hc->chan[channel].disorder_cnt;
-			hc->chan[channel].disorder_cnt = rx_counter;
-			rx_counter = cnt;
+			swap(hc->chan[channel].disorder_skb, nskb);
+			swap(hc->chan[channel].disorder_cnt, rx_counter);
 		}
 		}
 		hc->chan[channel].disorder_flag ^= 1;
 		hc->chan[channel].disorder_flag ^= 1;
 		if (nskb)
 		if (nskb)