浏览代码

tun: Use memdup_user() rather than duplicating its implementation

Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Markus Elfring 9 年之前
父节点
当前提交
28e8190d2f
共有 1 个文件被更改,包括 3 次插入8 次删除
  1. 3 8
      drivers/net/tun.c

+ 3 - 8
drivers/net/tun.c

@@ -731,14 +731,9 @@ static int update_filter(struct tap_filter *filter, void __user *arg)
 	}
 	}
 
 
 	alen = ETH_ALEN * uf.count;
 	alen = ETH_ALEN * uf.count;
-	addr = kmalloc(alen, GFP_KERNEL);
-	if (!addr)
-		return -ENOMEM;
-
-	if (copy_from_user(addr, arg + sizeof(uf), alen)) {
-		err = -EFAULT;
-		goto done;
-	}
+	addr = memdup_user(arg + sizeof(uf), alen);
+	if (IS_ERR(addr))
+		return PTR_ERR(addr);
 
 
 	/* The filter is updated without holding any locks. Which is
 	/* The filter is updated without holding any locks. Which is
 	 * perfectly safe. We disable it first and in the worst
 	 * perfectly safe. We disable it first and in the worst