Browse Source

IB/mthca: Use zeroing memory allocator than allocator/memset

Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Himanshu Jha 7 years ago
parent
commit
27f382da31
1 changed files with 2 additions and 3 deletions
  1. 2 3
      drivers/infiniband/hw/mthca/mthca_memfree.c

+ 2 - 3
drivers/infiniband/hw/mthca/mthca_memfree.c

@@ -623,13 +623,12 @@ int mthca_alloc_db(struct mthca_dev *dev, enum mthca_db_type type,
 	page = dev->db_tab->page + end;
 	page = dev->db_tab->page + end;
 
 
 alloc:
 alloc:
-	page->db_rec = dma_alloc_coherent(&dev->pdev->dev, MTHCA_ICM_PAGE_SIZE,
-					  &page->mapping, GFP_KERNEL);
+	page->db_rec = dma_zalloc_coherent(&dev->pdev->dev, MTHCA_ICM_PAGE_SIZE,
+					   &page->mapping, GFP_KERNEL);
 	if (!page->db_rec) {
 	if (!page->db_rec) {
 		ret = -ENOMEM;
 		ret = -ENOMEM;
 		goto out;
 		goto out;
 	}
 	}
-	memset(page->db_rec, 0, MTHCA_ICM_PAGE_SIZE);
 
 
 	ret = mthca_MAP_ICM_page(dev, page->mapping,
 	ret = mthca_MAP_ICM_page(dev, page->mapping,
 				 mthca_uarc_virt(dev, &dev->driver_uar, i));
 				 mthca_uarc_virt(dev, &dev->driver_uar, i));