瀏覽代碼

[media] dvb: Use DVBFE_ALGO_HW where applicable

The dvb_frontend.c core defines a FE_ALGO_HW symbol that it is
never used. Also, both cx24123 returns 1 to get_algo() callback
instead of using DVBFE_ALGO_HW.

Probably, those are some left overs from some code cleanup.

Let's stop returning magic numbers and use the proper macro
value.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Mauro Carvalho Chehab 10 年之前
父節點
當前提交
27460adc07
共有 3 個文件被更改,包括 2 次插入3 次删除
  1. 0 1
      drivers/media/dvb-core/dvb_frontend.c
  2. 1 1
      drivers/media/dvb-frontends/cx24123.c
  3. 1 1
      drivers/media/dvb-frontends/s921.c

+ 0 - 1
drivers/media/dvb-core/dvb_frontend.c

@@ -81,7 +81,6 @@ MODULE_PARM_DESC(dvb_mfe_wait_time, "Wait up to <mfe_wait_time> seconds on open(
 #define FESTATE_SEARCHING_SLOW (FESTATE_TUNING_SLOW | FESTATE_ZIGZAG_SLOW)
 #define FESTATE_SEARCHING_SLOW (FESTATE_TUNING_SLOW | FESTATE_ZIGZAG_SLOW)
 #define FESTATE_LOSTLOCK (FESTATE_ZIGZAG_FAST | FESTATE_ZIGZAG_SLOW)
 #define FESTATE_LOSTLOCK (FESTATE_ZIGZAG_FAST | FESTATE_ZIGZAG_SLOW)
 
 
-#define FE_ALGO_HW		1
 /*
 /*
  * FESTATE_IDLE. No tuning parameters have been supplied and the loop is idling.
  * FESTATE_IDLE. No tuning parameters have been supplied and the loop is idling.
  * FESTATE_RETUNE. Parameters have been supplied, but we have not yet performed the first tune.
  * FESTATE_RETUNE. Parameters have been supplied, but we have not yet performed the first tune.

+ 1 - 1
drivers/media/dvb-frontends/cx24123.c

@@ -1011,7 +1011,7 @@ static int cx24123_tune(struct dvb_frontend *fe,
 
 
 static int cx24123_get_algo(struct dvb_frontend *fe)
 static int cx24123_get_algo(struct dvb_frontend *fe)
 {
 {
-	return 1; /* FE_ALGO_HW */
+	return DVBFE_ALGO_HW;
 }
 }
 
 
 static void cx24123_release(struct dvb_frontend *fe)
 static void cx24123_release(struct dvb_frontend *fe)

+ 1 - 1
drivers/media/dvb-frontends/s921.c

@@ -466,7 +466,7 @@ static int s921_tune(struct dvb_frontend *fe,
 
 
 static int s921_get_algo(struct dvb_frontend *fe)
 static int s921_get_algo(struct dvb_frontend *fe)
 {
 {
-	return 1; /* FE_ALGO_HW */
+	return DVBFE_ALGO_HW;
 }
 }
 
 
 static void s921_release(struct dvb_frontend *fe)
 static void s921_release(struct dvb_frontend *fe)