瀏覽代碼

amd-xgbe: Don't overwrite SFP PHY mod_absent settings

If an SFP module is not present, xgbe_phy_sfp_phy_settings() should
return after applying the default settings. Currently there is no return
statement and the default settings are overwritten.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Lendacky, Thomas 8 年之前
父節點
當前提交
2697ea5a85
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c

+ 2 - 0
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c

@@ -716,6 +716,8 @@ static void xgbe_phy_sfp_phy_settings(struct xgbe_prv_data *pdata)
 		pdata->phy.duplex = DUPLEX_UNKNOWN;
 		pdata->phy.autoneg = AUTONEG_ENABLE;
 		pdata->phy.advertising = pdata->phy.supported;
+
+		return;
 	}
 
 	pdata->phy.advertising &= ~ADVERTISED_Autoneg;