Bladeren bron

drm/msm: Deletion of unnecessary checks before two function calls

The functions framebuffer_release() and vunmap() perform also input
parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Markus Elfring 10 jaren geleden
bovenliggende
commit
264f7d673f
2 gewijzigde bestanden met toevoegingen van 2 en 4 verwijderingen
  1. 1 2
      drivers/gpu/drm/msm/msm_fbdev.c
  2. 1 2
      drivers/gpu/drm/msm/msm_gem.c

+ 1 - 2
drivers/gpu/drm/msm/msm_fbdev.c

@@ -190,8 +190,7 @@ fail_unlock:
 fail:
 
 	if (ret) {
-		if (fbi)
-			framebuffer_release(fbi);
+		framebuffer_release(fbi);
 		if (fb) {
 			drm_framebuffer_unregister_private(fb);
 			drm_framebuffer_remove(fb);

+ 1 - 2
drivers/gpu/drm/msm/msm_gem.c

@@ -535,8 +535,7 @@ void msm_gem_free_object(struct drm_gem_object *obj)
 			drm_free_large(msm_obj->pages);
 
 	} else {
-		if (msm_obj->vaddr)
-			vunmap(msm_obj->vaddr);
+		vunmap(msm_obj->vaddr);
 		put_pages(obj);
 	}