Explorar o código

bluetooth: hci_qca: Replace GFP_ATOMIC with GFP_KERNEL

qca_open() and qca_set_baudrate() are never called in atomic context.

They call kzalloc() and bt_skb_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Jia-Ju Bai %!s(int64=7) %!d(string=hai) anos
pai
achega
25a13e382d
Modificáronse 1 ficheiros con 2 adicións e 2 borrados
  1. 2 2
      drivers/bluetooth/hci_qca.c

+ 2 - 2
drivers/bluetooth/hci_qca.c

@@ -405,7 +405,7 @@ static int qca_open(struct hci_uart *hu)
 
 
 	BT_DBG("hu %p qca_open", hu);
 	BT_DBG("hu %p qca_open", hu);
 
 
-	qca = kzalloc(sizeof(struct qca_data), GFP_ATOMIC);
+	qca = kzalloc(sizeof(struct qca_data), GFP_KERNEL);
 	if (!qca)
 	if (!qca)
 		return -ENOMEM;
 		return -ENOMEM;
 
 
@@ -891,7 +891,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
 
 
 	cmd[4] = baudrate;
 	cmd[4] = baudrate;
 
 
-	skb = bt_skb_alloc(sizeof(cmd), GFP_ATOMIC);
+	skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
 	if (!skb) {
 	if (!skb) {
 		bt_dev_err(hdev, "Failed to allocate baudrate packet");
 		bt_dev_err(hdev, "Failed to allocate baudrate packet");
 		return -ENOMEM;
 		return -ENOMEM;