Browse Source

fsl/fman: Add a missing 'of_node_put()' call in an error handling path

If 'of_phy_find_device()' fails, we must undo the previous 'of_node_get()'
call, as done the the following error handling code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Christophe JAILLET 7 years ago
parent
commit
25850c31c8
1 changed files with 1 additions and 0 deletions
  1. 1 0
      drivers/net/ethernet/freescale/fman/mac.c

+ 1 - 0
drivers/net/ethernet/freescale/fman/mac.c

@@ -821,6 +821,7 @@ static int mac_probe(struct platform_device *_of_dev)
 		phy = of_phy_find_device(mac_dev->phy_node);
 		phy = of_phy_find_device(mac_dev->phy_node);
 		if (!phy) {
 		if (!phy) {
 			err = -EINVAL;
 			err = -EINVAL;
+			of_node_put(mac_dev->phy_node);
 			goto _return_of_get_parent;
 			goto _return_of_get_parent;
 		}
 		}