Home Explore Help
Sign In
GfA
/
linux_kernel
5
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

tags: Fix DEFINE_PER_CPU expansions

$ make tags
  GEN     tags
ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1"
ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1"
ctags: Warning: kernel/locking/lockdep.c:151: null expansion of name pattern "\1"
ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1"
ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1"
ctags: Warning: kernel/workqueue.c:323: null expansion of name pattern "\1"
ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1"
ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1"
ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1"

Which are all the result of the DEFINE_PER_CPU pattern:

  scripts/tags.sh:200:	'/\<DEFINE_PER_CPU([^,]*, *\([[:alnum:]_]*\)/\1/v/'
  scripts/tags.sh:201:	'/\<DEFINE_PER_CPU_SHARED_ALIGNED([^,]*, *\([[:alnum:]_]*\)/\1/v/'

The below cures them. All except the workqueue one are within reasonable
distance of the 80 char limit. TJ do you have any preference on how to
fix the wq one, or shall we just not care its too long?

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Peter Zijlstra 9 years ago
parent
e6fd1fb3b5
commit
25528213fe
8 changed files with 13 additions and 18 deletions
Split View Show Diff Stats
  1. 2 2
      drivers/acpi/processor_idle.c
  2. 3 2
      drivers/xen/events/events_2l.c
  3. 1 2
      kernel/locking/lockdep.c
  4. 2 4
      kernel/rcu/rcutorture.c
  5. 1 2
      kernel/workqueue.c
  6. 1 2
      net/ipv4/syncookies.c
  7. 1 2
      net/ipv6/syncookies.c
  8. 2 2
      net/rds/page.c

+ 2 - 2
drivers/acpi/processor_idle.c
View File 

@@ -61,8 +61,8 @@ module_param(latency_factor, uint, 0644);
 
 
 static DEFINE_PER_CPU(struct cpuidle_device *, acpi_cpuidle_device);
 
 
-static DEFINE_PER_CPU(struct acpi_processor_cx * [CPUIDLE_STATE_MAX],
 
-								acpi_cstate);
 
+static
 
+DEFINE_PER_CPU(struct acpi_processor_cx * [CPUIDLE_STATE_MAX], acpi_cstate);
 
 
 static int disabled_by_idle_boot_param(void)
 
 {

+ 3 - 2
drivers/xen/events/events_2l.c
View File 

@@ -38,8 +38,9 @@
 
 /* Find the first set bit in a evtchn mask */
 
 #define EVTCHN_FIRST_BIT(w) find_first_bit(BM(&(w)), BITS_PER_EVTCHN_WORD)
 
 
-static DEFINE_PER_CPU(xen_ulong_t [EVTCHN_2L_NR_CHANNELS/BITS_PER_EVTCHN_WORD],
 
-		      cpu_evtchn_mask);
 
+#define EVTCHN_MASK_SIZE (EVTCHN_2L_NR_CHANNELS/BITS_PER_EVTCHN_WORD)
 
+
 
+static DEFINE_PER_CPU(xen_ulong_t [EVTCHN_MASK_SIZE], cpu_evtchn_mask);
 
 
 static unsigned evtchn_2l_max_channels(void)
 
 {

+ 1 - 2
kernel/locking/lockdep.c
View File 

@@ -148,8 +148,7 @@ static inline struct lock_class *hlock_class(struct held_lock *hlock)
 
 }
 
 
 #ifdef CONFIG_LOCK_STAT
 
-static DEFINE_PER_CPU(struct lock_class_stats[MAX_LOCKDEP_KEYS],
 
-		      cpu_lock_stats);
 
+static DEFINE_PER_CPU(struct lock_class_stats[MAX_LOCKDEP_KEYS], cpu_lock_stats);
 
 
 static inline u64 lockstat_clock(void)
 
 {

+ 2 - 4
kernel/rcu/rcutorture.c
View File 

@@ -130,10 +130,8 @@ static struct rcu_torture __rcu *rcu_torture_current;
 
 static unsigned long rcu_torture_current_version;
 
 static struct rcu_torture rcu_tortures[10 * RCU_TORTURE_PIPE_LEN];
 
 static DEFINE_SPINLOCK(rcu_torture_lock);
 
-static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1],
 
-		      rcu_torture_count) = { 0 };
 
-static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1],
 
-		      rcu_torture_batch) = { 0 };
 
+static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_count) = { 0 };
 
+static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) = { 0 };
 
 static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
 
 static atomic_t n_rcu_torture_alloc;
 
 static atomic_t n_rcu_torture_alloc_fail;

+ 1 - 2
kernel/workqueue.c
View File 

@@ -320,8 +320,7 @@ static bool wq_debug_force_rr_cpu = false;
 
 module_param_named(debug_force_rr_cpu, wq_debug_force_rr_cpu, bool, 0644);
 
 
 /* the per-cpu worker pools */
 
-static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS],
 
-				     cpu_worker_pools);
 
+static DEFINE_PER_CPU_SHARED_ALIGNED(struct worker_pool [NR_STD_WORKER_POOLS], cpu_worker_pools);
 
 
 static DEFINE_IDR(worker_pool_idr);	/* PR: idr of all pools */

+ 1 - 2
net/ipv4/syncookies.c
View File 

@@ -50,8 +50,7 @@ static u32 syncookie_secret[2][16-4+SHA_DIGEST_WORDS] __read_mostly;
 
 #define TSBITS	6
 
 #define TSMASK	(((__u32)1 << TSBITS) - 1)
 
 
-static DEFINE_PER_CPU(__u32 [16 + 5 + SHA_WORKSPACE_WORDS],
 
-		      ipv4_cookie_scratch);
 
+static DEFINE_PER_CPU(__u32 [16 + 5 + SHA_WORKSPACE_WORDS], ipv4_cookie_scratch);
 
 
 static u32 cookie_hash(__be32 saddr, __be32 daddr, __be16 sport, __be16 dport,
 
 		       u32 count, int c)

+ 1 - 2
net/ipv6/syncookies.c
View File 

@@ -41,8 +41,7 @@ static __u16 const msstab[] = {
 
 	9000 - 60,
 
 };
 
 
-static DEFINE_PER_CPU(__u32 [16 + 5 + SHA_WORKSPACE_WORDS],
 
-		      ipv6_cookie_scratch);
 
+static DEFINE_PER_CPU(__u32 [16 + 5 + SHA_WORKSPACE_WORDS], ipv6_cookie_scratch);
 
 
 static u32 cookie_hash(const struct in6_addr *saddr, const struct in6_addr *daddr,
 
 		       __be16 sport, __be16 dport, u32 count, int c)

+ 2 - 2
net/rds/page.c
View File 

@@ -42,8 +42,8 @@ struct rds_page_remainder {
 
 	unsigned long	r_offset;
 
 };
 
 
-static DEFINE_PER_CPU_SHARED_ALIGNED(struct rds_page_remainder,
 
-				     rds_page_remainders);
 
+static
 
+DEFINE_PER_CPU_SHARED_ALIGNED(struct rds_page_remainder, rds_page_remainders);
 
 
 /*
 
  * returns 0 on success or -errno on failure.