Browse Source

usb: chipidea: debug: disable usb irq while role switch

Since the ci->role will be set after the host role start is complete, there
will be nobody cared irq during start host if usb irq enabled. This error
can be reproduced on i.mx6 sololite EVK board by:
1. disable otg id irq(IDIE) and disable all real otg properties of usbotg1
   in dts.
2. boot up the board with ID cable and usb device connected.
3. echo gadget > /sys/kernel/debug/ci_hdrc.0/role
4. echo host > /sys/kernel/debug/ci_hdrc.0/role
5. irq 212: nobody cared.

Cc: <stable@vger.kernel.org> # v3.10+
Signed-off-by: Li Jun <jun.li@freescale.com>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Li Jun 9 years ago
parent
commit
251b3c8b57
1 changed files with 2 additions and 0 deletions
  1. 2 0
      drivers/usb/chipidea/debug.c

+ 2 - 0
drivers/usb/chipidea/debug.c

@@ -322,8 +322,10 @@ static ssize_t ci_role_write(struct file *file, const char __user *ubuf,
 		return -EINVAL;
 		return -EINVAL;
 
 
 	pm_runtime_get_sync(ci->dev);
 	pm_runtime_get_sync(ci->dev);
+	disable_irq(ci->irq);
 	ci_role_stop(ci);
 	ci_role_stop(ci);
 	ret = ci_role_start(ci, role);
 	ret = ci_role_start(ci, role);
+	enable_irq(ci->irq);
 	pm_runtime_put_sync(ci->dev);
 	pm_runtime_put_sync(ci->dev);
 
 
 	return ret ? ret : count;
 	return ret ? ret : count;